All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform
Date: Sat, 26 Oct 2013 22:28:19 -0400	[thread overview]
Message-ID: <87a9hvla64.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1382533396-6584-1-git-send-email-zhangfei.gao@linaro.org> (Zhangfei Gao's message of "Wed, 23 Oct 2013 21:03:16 +0800")

Hi Zhangfei, just small changes,

On Wed, Oct 23 2013, Zhangfei Gao wrote:
> +* tune-table: should be array of clock tune mmc controller

This sounds like it should be "tuning-table", and shouldn't it also
have a prefix?

> +			node = of_find_compatible_node(NULL, NULL,
> +						"hisilicon,pctrl");

No need to use two lines here.

> +		ret = of_property_read_u32_array(np,
> +				"clken-reg", data, 2);

Or here, same with the other of_property_read_u32_array() calls.

> +MODULE_DESCRIPTION("K3 Specific DW-MSHC Driver Extension");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:dwmmc-k3");

Can you add a MODULE_AUTHOR too?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>

WARNING: multiple messages have this Message-ID (diff)
From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform
Date: Sat, 26 Oct 2013 22:28:19 -0400	[thread overview]
Message-ID: <87a9hvla64.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1382533396-6584-1-git-send-email-zhangfei.gao@linaro.org> (Zhangfei Gao's message of "Wed, 23 Oct 2013 21:03:16 +0800")

Hi Zhangfei, just small changes,

On Wed, Oct 23 2013, Zhangfei Gao wrote:
> +* tune-table: should be array of clock tune mmc controller

This sounds like it should be "tuning-table", and shouldn't it also
have a prefix?

> +			node = of_find_compatible_node(NULL, NULL,
> +						"hisilicon,pctrl");

No need to use two lines here.

> +		ret = of_property_read_u32_array(np,
> +				"clken-reg", data, 2);

Or here, same with the other of_property_read_u32_array() calls.

> +MODULE_DESCRIPTION("K3 Specific DW-MSHC Driver Extension");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:dwmmc-k3");

Can you add a MODULE_AUTHOR too?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>

  reply	other threads:[~2013-10-27  2:28 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21  7:13 [v2 PATCH 0/2] mmc: dw_mmc: add dw_mmc-k3 Zhangfei Gao
2013-10-21  7:13 ` Zhangfei Gao
2013-10-21  7:13 ` [PATCH 1/2] mmc: dw_mmc: add dw_mci_of_get_cd_gpio to handle cd pin Zhangfei Gao
2013-10-21  7:13   ` Zhangfei Gao
     [not found] ` <1382339639-16764-1-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-10-21  7:13   ` [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform Zhangfei Gao
2013-10-21  7:13     ` Zhangfei Gao
2013-10-23 13:03     ` Zhangfei Gao
2013-10-23 13:03       ` Zhangfei Gao
2013-10-27  2:28       ` Chris Ball [this message]
2013-10-27  2:28         ` Chris Ball
2013-10-28  6:29       ` Kumar Gala
2013-10-28  6:29         ` Kumar Gala
2013-10-29  7:02         ` zhangfei gao
2013-10-29  7:02           ` zhangfei gao
2013-11-01  6:24       ` Seungwon Jeon
2013-11-01  6:24         ` Seungwon Jeon
2013-11-01  7:13         ` zhangfei gao
2013-11-01  7:13           ` zhangfei gao
2013-11-01  8:21           ` Seungwon Jeon
2013-11-01  8:21             ` Seungwon Jeon
2013-11-01 19:31             ` zhangfei gao
2013-11-01 19:31               ` zhangfei gao
  -- strict thread matches above, loose matches on Subject: below --
2013-11-08  5:38 [PATCH v3 0/2] mmc: dw_mmc: add dw_mmc-k3 Zhangfei Gao
2013-11-08  5:38 ` [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform Zhangfei Gao
2013-11-08  5:38   ` Zhangfei Gao
2013-12-05 14:00   ` Seungwon Jeon
2013-12-05 14:00     ` Seungwon Jeon
2013-12-11  5:47     ` Zhangfei Gao
2013-12-11  5:47       ` Zhangfei Gao
2013-12-05 14:29   ` Rob Herring
2013-12-05 14:29     ` Rob Herring
2013-12-11  5:55     ` Zhangfei Gao
2013-12-11  5:55       ` Zhangfei Gao
2013-12-06  1:39   ` Arnd Bergmann
2013-12-06  1:39     ` Arnd Bergmann
2013-12-11  3:31     ` Zhangfei Gao
2013-12-11  3:31       ` Zhangfei Gao
2013-12-11  3:45       ` Arnd Bergmann
2013-12-11  3:45         ` Arnd Bergmann
2013-12-11 18:48         ` Dinh Nguyen
2013-12-11 18:48           ` Dinh Nguyen
2013-12-11 23:40           ` Heiko Stübner
2013-12-11 23:40             ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9hvla64.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jh80.chung@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.