From: Thomas Rast <trast@inf.ethz.ch>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
<git@vger.kernel.org>
Subject: Re: [PATCH v2] urlmatch.c: recompute ptr after append_normalized_escapes
Date: Thu, 12 Sep 2013 17:25:02 +0200 [thread overview]
Message-ID: <87a9jidpv5.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <c8915eaaf877abe0e69864ffdc6c50f@f74d39fa044aa309eaea14b9f57fe79> (Kyle J. McKay's message of "Thu, 12 Sep 2013 07:15:40 -0700")
"Kyle J. McKay" <mackyle@gmail.com> writes:
> Also some nits. The patch description should be imperative mood
> (cf. Documentation/SubmittingPatches).
Heh. Serves me right to go away for a while and get SubmittingPatches
cited at me on return ;-)
Thanks for the updated patch. I agree with the changes. I particularly
like the better variable name.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2013-09-12 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 9:57 [PATCH] urlmatch: append_normalized_escapes can reallocate norm.buf Thomas Rast
2013-09-12 14:15 ` [PATCH v2] urlmatch.c: recompute ptr after append_normalized_escapes Kyle J. McKay
2013-09-12 15:25 ` Thomas Rast [this message]
2013-09-12 18:23 ` Junio C Hamano
2013-09-12 18:30 ` Junio C Hamano
2013-09-12 20:38 ` Kyle J. McKay
2013-09-12 22:05 ` Jonathan Nieder
2013-09-12 22:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9jidpv5.fsf@linux-k42r.v.cablecom.net \
--to=trast@inf.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mackyle@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.