All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH V10 04/13] perf tools: change machine__findnew_thread() to set thread pid
Date: Tue, 13 Aug 2013 12:01:42 +0900	[thread overview]
Message-ID: <87a9kmway1.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1376045519-13832-5-git-send-email-adrian.hunter@intel.com> (Adrian Hunter's message of "Fri, 9 Aug 2013 13:51:50 +0300")

On Fri,  9 Aug 2013 13:51:50 +0300, Adrian Hunter wrote:
> Add a new parameter for 'pid' to machine__findnew_thread().
> Change callers to pass 'pid' when it is known.

I think the changelog should mention the subtlety of passing pid/tid to
prevent possible future misusages.

Thanks,
Namhyung

  reply	other threads:[~2013-08-13  3:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09 10:51 [PATCH V10 00/13] perf tools: some fixes and tweaks Adrian Hunter
2013-08-09 10:51 ` [PATCH V10 01/13] perf tools: add debug prints Adrian Hunter
2013-08-13  2:54   ` Namhyung Kim
2013-08-14 11:05     ` Adrian Hunter
2013-08-09 10:51 ` [PATCH V10 02/13] perf tools: allow non-matching sample types Adrian Hunter
2013-08-09 10:51 ` [PATCH V10 03/13] perf tools: add pid to struct thread Adrian Hunter
2013-08-09 10:51 ` [PATCH V10 04/13] perf tools: change machine__findnew_thread() to set thread pid Adrian Hunter
2013-08-13  3:01   ` Namhyung Kim [this message]
2013-08-09 10:51 ` [PATCH V10 05/13] perf tools: tidy up sample parsing overflow checking Adrian Hunter
2013-08-13 18:04   ` Jiri Olsa
2013-08-09 10:51 ` [PATCH V10 06/13] perf tools: remove unnecessary callchain validation Adrian Hunter
2013-08-13  3:33   ` Namhyung Kim
2013-08-09 10:51 ` [PATCH V10 07/13] perf tools: remove references to struct ip_event Adrian Hunter
2013-08-13  3:35   ` Namhyung Kim
2013-08-09 10:51 ` [PATCH V10 08/13] perf: make events stream always parsable Adrian Hunter
2013-08-09 10:51 ` [PATCH V10 09/13] perf tools: move perf_evlist__config() to a new source file Adrian Hunter
2013-08-13  3:39   ` Namhyung Kim
2013-08-09 10:51 ` [PATCH V10 10/13] perf tools: add support for PERF_SAMPLE_IDENTFIER Adrian Hunter
2013-08-09 10:51 ` [PATCH V10 11/13] perf tools: expand perf_event__synthesize_sample() Adrian Hunter
2013-08-13 18:18   ` Jiri Olsa
2013-08-09 10:51 ` [PATCH V10 12/13] perf tools: add a function to calculate sample event size Adrian Hunter
2013-08-13 18:22   ` Jiri Olsa
2013-08-09 10:51 ` [PATCH V10 13/13] perf tools: add a sample parsing test Adrian Hunter
2013-08-13 18:23   ` Jiri Olsa
2013-08-09 13:41 ` [PATCH V10 00/13] perf tools: some fixes and tweaks Stephane Eranian
2013-08-09 13:59   ` Adrian Hunter
2013-08-09 13:58     ` Stephane Eranian
2013-08-09 18:16       ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9kmway1.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.