From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman)
To: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kent.overstreet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Glauber Costa <glommer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: memcg creates an unkillable task in 3.2-rc2
Date: Mon, 29 Jul 2013 11:52:11 -0700 [thread overview]
Message-ID: <87a9l5w65g.fsf@xmission.com> (raw)
In-Reply-To: <20130729181354.GX715-druUgvl0LCNAfugRpC6u6w@public.gmane.org> (Johannes Weiner's message of "Mon, 29 Jul 2013 14:13:54 -0400")
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> writes:
> On Mon, Jul 29, 2013 at 10:03:35AM -0700, Eric W. Biederman wrote:
>> Yes. From the looks of the looks of it the cgroup implementation is
>> rather badly borked right now, and definitely not up to the standards of
>> the other core pieces of the kernel. One of the reasons I was rather
>> apalled when systemd started using them. Until the code actually works
>> reliably and the races are removed most people's systems would be much
>> better off with cgroups compiled out.
>>
>> A single unified hierarchy is a really nasty idea for the same set of
>> reasons. You have to recompile to disable a controller to see if it that
>> controller's bugs are what are causing problems on your production
>> system. Compiles or even just a reboot is a very heavy hammer to ask
>> people to use when they are triaging a problem.
>
> That's not how it works. You can always select which controllers you
> want to mount during runtime. Unified hierarchy only means that there
> is one cgroup tree for all mounted controllers, rather than every
> controller having its own separate cgroup tree.
>
> If you are like most users and currently mount all controllers in the
> same directory so that their cgroup trees overlap and appear to be a
> single tree, nothing changes for you.
My practical need is that I need the ability modify which controllers I
am using on a per group basis. So that I can make corrall new processes
in a different set of controllers than currently existing processes.
I might just be missing something but I don't see how to do that with
all of the controllers mounted to the same filesystem.
So while I currently have a single mount of cgroupfs, and don't yet see
a need for orthogonal classification of processes. To keep bugs and
craziness under control I expect I will be implementing a mount of
cgroupfs per controller within a month.
But except for the need to limit the scope of bugs this is all getting
rather badly off topic.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Tejun Heo <tj@kernel.org>, Michal Hocko <mhocko@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
cgroups@vger.kernel.org, containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, kent.overstreet@gmail.com,
Li Zefan <lizefan@huawei.com>, Glauber Costa <glommer@gmail.com>
Subject: Re: memcg creates an unkillable task in 3.2-rc2
Date: Mon, 29 Jul 2013 11:52:11 -0700 [thread overview]
Message-ID: <87a9l5w65g.fsf@xmission.com> (raw)
In-Reply-To: <20130729181354.GX715@cmpxchg.org> (Johannes Weiner's message of "Mon, 29 Jul 2013 14:13:54 -0400")
Johannes Weiner <hannes@cmpxchg.org> writes:
> On Mon, Jul 29, 2013 at 10:03:35AM -0700, Eric W. Biederman wrote:
>> Yes. From the looks of the looks of it the cgroup implementation is
>> rather badly borked right now, and definitely not up to the standards of
>> the other core pieces of the kernel. One of the reasons I was rather
>> apalled when systemd started using them. Until the code actually works
>> reliably and the races are removed most people's systems would be much
>> better off with cgroups compiled out.
>>
>> A single unified hierarchy is a really nasty idea for the same set of
>> reasons. You have to recompile to disable a controller to see if it that
>> controller's bugs are what are causing problems on your production
>> system. Compiles or even just a reboot is a very heavy hammer to ask
>> people to use when they are triaging a problem.
>
> That's not how it works. You can always select which controllers you
> want to mount during runtime. Unified hierarchy only means that there
> is one cgroup tree for all mounted controllers, rather than every
> controller having its own separate cgroup tree.
>
> If you are like most users and currently mount all controllers in the
> same directory so that their cgroup trees overlap and appear to be a
> single tree, nothing changes for you.
My practical need is that I need the ability modify which controllers I
am using on a per group basis. So that I can make corrall new processes
in a different set of controllers than currently existing processes.
I might just be missing something but I don't see how to do that with
all of the controllers mounted to the same filesystem.
So while I currently have a single mount of cgroupfs, and don't yet see
a need for orthogonal classification of processes. To keep bugs and
craziness under control I expect I will be implementing a mount of
cgroupfs per controller within a month.
But except for the need to limit the scope of bugs this is all getting
rather badly off topic.
Eric
next prev parent reply other threads:[~2013-07-29 18:52 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 17:47 [GIT PULL] cgroup changes for 3.11-rc2 Tejun Heo
2013-07-23 17:47 ` Tejun Heo
[not found] ` <20130723174711.GE21100-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-07-29 0:42 ` memcg creates an unkillable task in 3.2-rc2 Eric W. Biederman
2013-07-29 0:42 ` Eric W. Biederman
[not found] ` <8761vui4cr.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-07-29 7:59 ` Michal Hocko
2013-07-29 7:59 ` Michal Hocko
[not found] ` <20130729075939.GA4678-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-07-29 8:54 ` Eric W. Biederman
2013-07-29 8:54 ` Eric W. Biederman
[not found] ` <87ehahg312.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-07-29 9:51 ` Michal Hocko
2013-07-29 9:51 ` Michal Hocko
[not found] ` <20130729095109.GB4678-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-07-29 10:21 ` Eric W. Biederman
2013-07-29 10:21 ` Eric W. Biederman
2013-07-29 10:21 ` Eric W. Biederman
2013-07-29 16:10 ` Tejun Heo
2013-07-29 16:10 ` Tejun Heo
2013-07-29 16:10 ` Tejun Heo
[not found] ` <20130729161026.GD22605-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-07-29 17:03 ` Eric W. Biederman
2013-07-29 17:03 ` Eric W. Biederman
[not found] ` <87r4eh70yg.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-07-29 17:20 ` Tejun Heo
2013-07-29 17:20 ` Tejun Heo
[not found] ` <20130729172046.GI22605-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-07-29 18:06 ` Eric W. Biederman
2013-07-29 18:06 ` Eric W. Biederman
2013-07-29 18:06 ` Eric W. Biederman
2013-07-29 18:17 ` Michal Hocko
2013-07-29 18:17 ` Michal Hocko
2013-07-29 18:17 ` Michal Hocko
2013-07-29 17:20 ` Tejun Heo
2013-07-29 18:13 ` Johannes Weiner
2013-07-29 18:13 ` Johannes Weiner
[not found] ` <20130729181354.GX715-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-07-29 18:52 ` Eric W. Biederman
2013-07-29 18:52 ` Eric W. Biederman [this message]
2013-07-29 18:52 ` Eric W. Biederman
2013-07-30 1:58 ` Li Zefan
2013-07-30 1:58 ` Li Zefan
2013-07-30 1:58 ` Li Zefan
[not found] ` <51F71DE2.4020102-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-30 8:19 ` memcg creates an unkillable task in 3.11-rc2 Eric W. Biederman
2013-07-30 8:19 ` Eric W. Biederman
[not found] ` <87ppu0a298.fsf_-_-HxuHnoDHeQZYhcs0q7wBk77fW72O3V7zAL8bYrjMMd8@public.gmane.org>
2013-07-30 12:31 ` Michal Hocko
2013-07-30 12:31 ` Michal Hocko
[not found] ` <20130730123120.GA15847-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-07-30 16:37 ` Eric W. Biederman
2013-07-30 16:37 ` Eric W. Biederman
2013-07-30 16:37 ` Eric W. Biederman
[not found] ` <874nbc3sx1.fsf-HxuHnoDHeQZYhcs0q7wBk77fW72O3V7zAL8bYrjMMd8@public.gmane.org>
2013-07-31 7:37 ` Michal Hocko
2013-07-31 7:37 ` Michal Hocko
[not found] ` <20130731073726.GC30514-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-07-31 12:10 ` Johannes Weiner
2013-07-31 12:10 ` Johannes Weiner
2013-07-31 12:10 ` Johannes Weiner
2013-07-31 22:09 ` Eric W. Biederman
2013-07-31 22:09 ` Eric W. Biederman
2013-07-31 22:09 ` Eric W. Biederman
[not found] ` <87zjt2tm9f.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-08-01 9:06 ` Michal Hocko
2013-08-01 9:06 ` Michal Hocko
[not found] ` <20130801090620.GA5198-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-09-05 9:56 ` Michal Hocko
2013-09-05 9:56 ` Michal Hocko
[not found] ` <20130905095653.GB9702-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-09-06 18:09 ` Eric W. Biederman
2013-09-06 18:09 ` Eric W. Biederman
[not found] ` <87ob85kejy.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-09-09 8:31 ` Michal Hocko
2013-09-09 8:31 ` Michal Hocko
2013-09-09 8:31 ` Michal Hocko
2013-09-05 9:56 ` Michal Hocko
2013-07-30 16:28 ` Eric W. Biederman
2013-07-30 16:28 ` Eric W. Biederman
[not found] ` <87ppu03td7.fsf-HxuHnoDHeQZYhcs0q7wBk77fW72O3V7zAL8bYrjMMd8@public.gmane.org>
2013-09-26 23:41 ` Fabio Kung
2013-09-26 23:41 ` Fabio Kung
2013-09-26 23:41 ` Fabio Kung
[not found] ` <CAHyO6Z33pUJ1_MjPO2OeUY_+ZRmc1niPiFm5DzGVDokm5vb4rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-27 0:35 ` Eric W. Biederman
2013-09-27 0:35 ` Eric W. Biederman
2013-11-12 16:00 ` Michal Hocko
2013-11-12 16:00 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9l5w65g.fsf@xmission.com \
--to=ebiederm-as9lmozglivwk0htik3j/w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=glommer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kent.overstreet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.