From: Thomas Rast <trast@inf.ethz.ch>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH v2 2/2] send-email: add test for duplicate utf8 name
Date: Thu, 20 Jun 2013 14:41:37 +0200 [thread overview]
Message-ID: <87a9ml9cou.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <1371731166-24015-2-git-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Thu, 20 Jun 2013 15:27:05 +0300")
"Michael S. Tsirkin" <mst@redhat.com> writes:
> Verify that author name is not duplicated if it matches
> sender, even if it is in utf8.
Small nit: if you make two patches out of it, add the tests first with
test_expect_failure. Then flip it to test_expect_success in the actual
code change. That makes it easy to verify that the test actually checks
the right thing, and that it was your code change that fixed it.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2013-06-20 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 12:27 [PATCH v2 1/2] send-email: sanitize author when writing From line Michael S. Tsirkin
2013-06-20 12:27 ` [PATCH v2 2/2] send-email: add test for duplicate utf8 name Michael S. Tsirkin
2013-06-20 12:41 ` Thomas Rast [this message]
2013-06-20 12:45 ` Michael S. Tsirkin
2013-06-20 12:48 ` Thomas Rast
2013-06-20 12:53 ` Michael S. Tsirkin
2013-06-20 19:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9ml9cou.fsf@linux-k42r.v.cablecom.net \
--to=trast@inf.ethz.ch \
--cc=git@vger.kernel.org \
--cc=mst@redhat.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.