From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 1/7] drm/i915: Mark context switch likely
Date: Mon, 08 Apr 2013 09:06:02 +0300
Message-ID: <87a9p9r1yt.fsf@intel.com>
References: <1365118914-15753-1-git-send-email-ben@bwidawsk.net>
	<1365118914-15753-2-git-send-email-ben@bwidawsk.net>
	<87d2u9qwqh.fsf@intel.com> <20130405164453.GA23599@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
	by gabe.freedesktop.org (Postfix) with ESMTP id D98AAE5C95
	for <intel-gfx@lists.freedesktop.org>;
	Sun,  7 Apr 2013 23:05:51 -0700 (PDT)
In-Reply-To: <20130405164453.GA23599@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 05 Apr 2013, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Fri, Apr 05, 2013 at 10:09:58AM +0300, Jani Nikula wrote:
>> Same goes for the unlikely in patches 4/7. (Yes, patch_es_ 4/7 - there's
>> *two* patches 4/7 in the series! :o)
>
> I don't see two, weird.

Hmm, it's not only my mail setup:

http://thread.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/20106/focus=20108

>> I'm just generally wary of adding (un)likely annotations. I don't think
>> it matters that the annotation itself is obviously correct; IMHO the
>> performance impact should matter.
>> 
>> </bikeshed>
>
> Right. I actually stuck it in by accident, and decided to keep it only
> because it serves as nice documentation. I suppose a comment would do
> the same thing, but this also had a chance (albeit slight) to improve
> things.

That's true too, and I do like code that documents itself. No biggie.


BR,
Jani.