From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org, David Gibson <dwg@au1.ibm.com>
Subject: Re: [PATCH -V3 2/3] powerpc: Update kernel VSID range
Date: Wed, 13 Mar 2013 14:47:06 +0530 [thread overview]
Message-ID: <87a9q7d5gt.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130313034254.GC21125@iris.ozlabs.ibm.com>
Paul Mackerras <paulus@samba.org> writes:
> On Tue, Mar 12, 2013 at 05:38:50PM +0530, Aneesh Kumar K.V wrote:
>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>>
>> This patch change the kernel VSID range so that we limit VSID_BITS to 37.
>> This enables us to support 64TB with 65 bit VA (37+28). Without this patch
>> we have boot hangs on platforms that only support 65 bit VA.
>>
>> With this patch we now have proto vsid generated as below:
>>
>> We first generate a 37-bit "proto-VSID". Proto-VSIDs are generated
>> from mmu context id and effective segment id of the address.
>>
>> For user processes max context id is limited to ((1ul << 19) - 5)
>> for kernel space, we use the top 4 context ids to map address as below
>> 0x7fffc - [ 0xc000000000000000 - 0xc0003fffffffffff ]
>> 0x7fffd - [ 0xd000000000000000 - 0xd0003fffffffffff ]
>> 0x7fffe - [ 0xe000000000000000 - 0xe0003fffffffffff ]
>> 0x7ffff - [ 0xf000000000000000 - 0xf0003fffffffffff ]
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> Mostly looks OK, and it could go in as is, so
>
> Acked-by: Paul Mackerras <paulus@samba.org>
>
> Some minor comments below...
>
>> + * For user processes max context id is limited to ((1ul << 19) - 6)
>
> should be ((1ul << 19) - 5)
I update the commit message but missed updating this.
Ben,
Let me know if you want me to send V4 to take care of these review
feedbacks.
-aneesh
next prev parent reply other threads:[~2013-03-13 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 12:08 [PATCH -V3 1/3] powerpc: Make VSID_BITS* dependency explicit Aneesh Kumar K.V
2013-03-12 12:08 ` [PATCH -V3 2/3] powerpc: Update kernel VSID range Aneesh Kumar K.V
2013-03-13 3:42 ` Paul Mackerras
2013-03-13 9:17 ` Aneesh Kumar K.V [this message]
2013-03-13 9:49 ` Benjamin Herrenschmidt
2013-03-13 13:44 ` Aneesh Kumar K.V
2013-03-12 12:08 ` [PATCH -V3 3/3] powerpc: rename USER_ESID_BITS* to ESID_BITS* Aneesh Kumar K.V
2013-03-13 3:43 ` Paul Mackerras
2013-03-13 3:43 ` [PATCH -V3 1/3] powerpc: Make VSID_BITS* dependency explicit Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9q7d5gt.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=dwg@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.