From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR Date: Fri, 23 Nov 2012 10:10:56 +0200 Message-ID: <87a9u8hh7z.fsf@intel.com> References: <1352842892-2810-1-git-send-email-andy.gross@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id BD37DE5C21 for ; Fri, 23 Nov 2012 00:10:36 -0800 (PST) In-Reply-To: <1352842892-2810-1-git-send-email-andy.gross@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Andy Gross , dri-devel@lists.freedesktop.org Cc: Rob Clark , Greg Kroah-Hartman List-Id: dri-devel@lists.freedesktop.org On Tue, 13 Nov 2012, Andy Gross wrote: > Return PTR_ERR(-ENOMEM) if dmm_txn_init cannot allocate a > refill engine. > > Signed-off-by: Andy Gross > --- > drivers/staging/omapdrm/omap_dmm_tiler.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/omapdrm/omap_dmm_tiler.c b/drivers/staging/omapdrm/omap_dmm_tiler.c > index 3ae3955..1a5a7ca 100644 > --- a/drivers/staging/omapdrm/omap_dmm_tiler.c > +++ b/drivers/staging/omapdrm/omap_dmm_tiler.c > @@ -279,7 +279,7 @@ static int fill(struct tcm_area *area, struct page **pages, > > txn = dmm_txn_init(omap_dmm, area->tcm); > if (IS_ERR_OR_NULL(txn)) > - return PTR_ERR(txn); > + return PTR_ERR(-ENOMEM); return -ENOMEM; BR, Jani. > > tcm_for_each_slice(slice, *area, area_s) { > struct pat_area p_area = { > -- > 1.7.5.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel