All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Kyoungil Kim <ki0351.kim@samsung.com>
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdio: To use multiple scatter gather list
Date: Sat, 17 Nov 2012 15:26:47 -0500	[thread overview]
Message-ID: <87a9ug9drs.fsf@octavius.laptop.org> (raw)
In-Reply-To: <001801cdbca7$0b12bc70$21383550$%kim@samsung.com> (Kyoungil Kim's message of "Wed, 07 Nov 2012 14:16:29 +0900")

Hi,

On Wed, Nov 07 2012, Kyoungil Kim wrote:
> On Tue, Oct 30 2012, Chris Ball wrote:
>> Hi,
>> 
>> On Mon, Oct 22 2012, Kyoungil Kim wrote:
>> > We used only single sg entry for SDIO transfer.
>> > This chagne is to use multiple sg entry.
>> > In case of dwmci, it support only up to 4KB size per single sg entry.
>> > So if we want to transfer more than 4KB, we should send more than
>> > 1 command.
>> > This makes performance degradation for large data transfer.
>> >
>> > Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
>> 
>> Can you share the before/after benchmark on your controller, please?
>
> When we test before apply this patch, it takes around 335 us for
> 5K(5120) bytes transfer with dwmci controller.
> But when we test after apply this patch, it takes 242 us for 5K bytes.
> So this patch makes around 38% performance improvement for 5K bytes transfer.
> If the transfer size is bigger, then the performance improvement ratio
> will be increased.

Thanks, pushed to mmc-next for 3.8.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

      reply	other threads:[~2012-11-17 20:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 11:01 [PATCH] mmc: sdio: To use multiple scatter gather list Kyoungil Kim
2012-10-29 21:20 ` Chris Ball
2012-11-07  5:16   ` Kyoungil Kim
2012-11-17 20:26     ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9ug9drs.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=ki0351.kim@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.