All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Oliver Neukum <oneukum@suse.de>,
	Sarah Sharp <sarah.a.sharp@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>, "Lan\,
	Tianyu" <tianyu.lan@intel.com>
Subject: Re: BUG: unable to handle kernel paging request in usb_match_id()
Date: Sun, 19 Aug 2012 12:23:38 +0200	[thread overview]
Message-ID: <87a9xrmb85.fsf@nemi.mork.no> (raw)
In-Reply-To: <CACVXFVMeUmLh=Tu3PHbgHQNX+c-z50_CoAkdJS_uCw=E3dO2dw@mail.gmail.com> (Ming Lei's message of "Sat, 18 Aug 2012 08:58:39 +0800")

Ming Lei <tom.leiming@gmail.com> writes:
> On Fri, Aug 17, 2012 at 10:42 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>> On Fri, Aug 17, 2012 at 10:38:16AM -0400, Alan Stern wrote:
>>> On Fri, 17 Aug 2012, Ming Lei wrote:
>>>
>>> > But,  if HOTPLUG is not enabled, should device_add() trigger driver probe
>>> > further after kernel init is completed?  Or even devices should be allowed
>>> > to add into system?
>>>
>>> Indeed, does it make any sense to have USB support at all if HOTPLUG
>>> isn't enabled?  Should USB select HOTPLUG?
>>
>> Well, a long time ago people wanted to use USB but not have HOTPLUG
>> enabled in their systems for various (odd) embedded systems.  As it's
>> pretty hard to even turn off HOTPLUG these days, I'd be more likely to
>> just remove CONFIG_HOTPLUG entirely given the dynamic nature of almost
>> all systems.
>
> It should make sense, otherwise all device id table should not use
> __devinit* markings. There are lots of pci driver usage on it.

You might want to start here then:

/**
 * DEFINE_PCI_DEVICE_TABLE - macro used to describe a pci device table
 * @_table: device table name
 *
 * This macro is used to create a struct pci_device_id array (a device table)
 * in a generic manner.
 */
#define DEFINE_PCI_DEVICE_TABLE(_table) \
        const struct pci_device_id _table[] __devinitconst



Bjørn

  reply	other threads:[~2012-08-19 10:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-05  2:59 BUG: unable to handle kernel paging request in usb_match_id() Fengguang Wu
2012-08-05 16:58 ` Greg Kroah-Hartman
2012-08-17  2:00   ` Fengguang Wu
2012-08-17  3:48     ` Greg Kroah-Hartman
2012-08-17  5:44       ` Fengguang Wu
2012-08-17  8:52         ` Bjørn Mork
2012-08-17  9:07           ` Bjørn Mork
2012-08-17  9:27             ` Fengguang Wu
2012-08-17 10:24               ` Fengguang Wu
2012-08-17 12:16                 ` Ming Lei
2012-08-17 13:45                   ` Greg Kroah-Hartman
2012-08-17 14:38                   ` Alan Stern
2012-08-17 14:42                     ` Greg Kroah-Hartman
2012-08-18  0:58                       ` Ming Lei
2012-08-19 10:23                         ` Bjørn Mork [this message]
2012-08-19 14:35                           ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9xrmb85.fsf@nemi.mork.no \
    --to=bjorn@mork.no \
    --cc=fengguang.wu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.de \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tianyu.lan@intel.com \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.