From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Szkox-0001FR-KO for qemu-devel@nongnu.org; Fri, 10 Aug 2012 04:43:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Szkow-00024X-NF for qemu-devel@nongnu.org; Fri, 10 Aug 2012 04:43:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Szkow-00024T-FS for qemu-devel@nongnu.org; Fri, 10 Aug 2012 04:43:50 -0400 From: Markus Armbruster References: <1344354826-10375-1-git-send-email-lcapitulino@redhat.com> <1344354826-10375-13-git-send-email-lcapitulino@redhat.com> Date: Fri, 10 Aug 2012 10:43:47 +0200 In-Reply-To: <1344354826-10375-13-git-send-email-lcapitulino@redhat.com> (Luiz Capitulino's message of "Tue, 7 Aug 2012 12:53:23 -0300") Message-ID: <87a9y3cf24.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 12/35] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, eblake@redhat.com Luiz Capitulino writes: > This commit changes hmp_cont() to loop through all block devices > and proactively set an encryption key for any encrypted device > without a valid one. > > This change is needed because QERR_DEVICE_ENCRYPTED is going to be > dropped by a future commit. I'm afraid this breaks for unencrypted images with encrypted backing files. See the reply to v1 12/34 I just sent.