From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSVpa-00050D-Nd for qemu-devel@nongnu.org; Thu, 10 May 2012 12:03:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSVpW-00014o-2k for qemu-devel@nongnu.org; Thu, 10 May 2012 12:03:06 -0400 Received: from mx.meyering.net ([88.168.87.75]:42103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSVpV-00014C-Ry for qemu-devel@nongnu.org; Thu, 10 May 2012 12:03:02 -0400 From: Jim Meyering In-Reply-To: <4FAB9204.9090109@redhat.com> (Kevin Wolf's message of "Thu, 10 May 2012 12:01:40 +0200") References: <1336555446-20180-1-git-send-email-jim@meyering.net> <4FAB9204.9090109@redhat.com> Date: Thu, 10 May 2012 18:02:59 +0200 Message-ID: <87aa1grpl8.fsf@rho.meyering.net> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] strncpy: best avoided (resend) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, Anthony Liguori Kevin Wolf wrote: > Am 09.05.2012 11:23, schrieb Jim Meyering: >> [Argh. First attempt omitted the most important address: qemu-devel. >> Sorry to all who get two copies. ] >> >> Given qemu's HACKING comments, I'm sure many here have read "man strncpy", >> where it indicates it is often not the best function to use. > > Anthony, I think it's best if you (or any other committer) can take the > whole series at once, so I didn't pick up the block patches in it but > just added my Acked-by. Hope that's okay with you. I can post a V2 series (with ACK and Reviewed-by comments already added) or push to a publicly accessible git server if that helps.