From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 2/6] gpio/omap: remove saved_wakeup field from struct gpio_bank Date: Mon, 27 Feb 2012 15:50:24 -0800 Message-ID: <87aa43vnsv.fsf@ti.com> References: <1329999031-6914-1-git-send-email-tarun.kanti@ti.com> <1329999031-6914-3-git-send-email-tarun.kanti@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog109.obsmtp.com ([74.125.149.201]:48577 "EHLO na3sys009aog109.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754672Ab2B0Xud (ORCPT ); Mon, 27 Feb 2012 18:50:33 -0500 Received: by mail-pw0-f52.google.com with SMTP id um15so8841016pbc.25 for ; Mon, 27 Feb 2012 15:50:26 -0800 (PST) In-Reply-To: <1329999031-6914-3-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Thu, 23 Feb 2012 17:40:27 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tarun Kanti DebBarma Cc: linux-omap@vger.kernel.org, grant.likely@secretlab.ca, tony@atomide.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Tarun Kanti DebBarma writes: > There is no more need to have saved_wakeup. Instead we can use > context.wake_en which holds the current wakeup enable register > context. This also means that the read from wakeup enable register > is not needed. > > Signed-off-by: Tarun Kanti DebBarma Looks right, but one question below... > --- > drivers/gpio/gpio-omap.c | 13 ++++--------- > 1 files changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index 40a1fb2..64f15d5 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -54,7 +54,6 @@ struct gpio_bank { > u16 irq; > u16 virtual_irq_start; > u32 suspend_wakeup; > - u32 saved_wakeup; > u32 non_wakeup_gpios; > u32 enabled_non_wakeup_gpios; > struct gpio_regs context; > @@ -772,7 +771,7 @@ static int omap_mpuio_suspend_noirq(struct device *dev) > unsigned long flags; > > spin_lock_irqsave(&bank->lock, flags); > - bank->saved_wakeup = __raw_readl(mask_reg); > + bank->context.wake_en = __raw_readl(mask_reg); Why is this read needed? Kevin > __raw_writel(0xffff & ~bank->suspend_wakeup, mask_reg); > spin_unlock_irqrestore(&bank->lock, flags); > From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Mon, 27 Feb 2012 15:50:24 -0800 Subject: [PATCH 2/6] gpio/omap: remove saved_wakeup field from struct gpio_bank In-Reply-To: <1329999031-6914-3-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Thu, 23 Feb 2012 17:40:27 +0530") References: <1329999031-6914-1-git-send-email-tarun.kanti@ti.com> <1329999031-6914-3-git-send-email-tarun.kanti@ti.com> Message-ID: <87aa43vnsv.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Tarun Kanti DebBarma writes: > There is no more need to have saved_wakeup. Instead we can use > context.wake_en which holds the current wakeup enable register > context. This also means that the read from wakeup enable register > is not needed. > > Signed-off-by: Tarun Kanti DebBarma Looks right, but one question below... > --- > drivers/gpio/gpio-omap.c | 13 ++++--------- > 1 files changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index 40a1fb2..64f15d5 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -54,7 +54,6 @@ struct gpio_bank { > u16 irq; > u16 virtual_irq_start; > u32 suspend_wakeup; > - u32 saved_wakeup; > u32 non_wakeup_gpios; > u32 enabled_non_wakeup_gpios; > struct gpio_regs context; > @@ -772,7 +771,7 @@ static int omap_mpuio_suspend_noirq(struct device *dev) > unsigned long flags; > > spin_lock_irqsave(&bank->lock, flags); > - bank->saved_wakeup = __raw_readl(mask_reg); > + bank->context.wake_en = __raw_readl(mask_reg); Why is this read needed? Kevin > __raw_writel(0xffff & ~bank->suspend_wakeup, mask_reg); > spin_unlock_irqrestore(&bank->lock, flags); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755950Ab2B0Xu2 (ORCPT ); Mon, 27 Feb 2012 18:50:28 -0500 Received: from na3sys009aog116.obsmtp.com ([74.125.149.240]:34525 "EHLO na3sys009aog116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754672Ab2B0Xu1 (ORCPT ); Mon, 27 Feb 2012 18:50:27 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of khilman@ti.com designates 10.68.72.70 as permitted sender) smtp.mail=khilman@ti.com From: Kevin Hilman To: Tarun Kanti DebBarma Cc: , , , , Subject: Re: [PATCH 2/6] gpio/omap: remove saved_wakeup field from struct gpio_bank Organization: Texas Instruments, Inc. References: <1329999031-6914-1-git-send-email-tarun.kanti@ti.com> <1329999031-6914-3-git-send-email-tarun.kanti@ti.com> Date: Mon, 27 Feb 2012 15:50:24 -0800 In-Reply-To: <1329999031-6914-3-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Thu, 23 Feb 2012 17:40:27 +0530") Message-ID: <87aa43vnsv.fsf@ti.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tarun Kanti DebBarma writes: > There is no more need to have saved_wakeup. Instead we can use > context.wake_en which holds the current wakeup enable register > context. This also means that the read from wakeup enable register > is not needed. > > Signed-off-by: Tarun Kanti DebBarma Looks right, but one question below... > --- > drivers/gpio/gpio-omap.c | 13 ++++--------- > 1 files changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index 40a1fb2..64f15d5 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -54,7 +54,6 @@ struct gpio_bank { > u16 irq; > u16 virtual_irq_start; > u32 suspend_wakeup; > - u32 saved_wakeup; > u32 non_wakeup_gpios; > u32 enabled_non_wakeup_gpios; > struct gpio_regs context; > @@ -772,7 +771,7 @@ static int omap_mpuio_suspend_noirq(struct device *dev) > unsigned long flags; > > spin_lock_irqsave(&bank->lock, flags); > - bank->saved_wakeup = __raw_readl(mask_reg); > + bank->context.wake_en = __raw_readl(mask_reg); Why is this read needed? Kevin > __raw_writel(0xffff & ~bank->suspend_wakeup, mask_reg); > spin_unlock_irqrestore(&bank->lock, flags); >