From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCHv2 RFC] virtio-spec: flexible configuration layout Date: Wed, 16 Nov 2011 10:28:52 +1030 Message-ID: <87aa7xos3n.fsf@rustcorp.com.au> References: <87wrbkvh3v.fsf@rustcorp.com.au> <20111101114542.GA13434@redhat.com> <1320150813.3847.24.camel@lappy> <20111101124223.GA14060@redhat.com> <8739e7uy87.fsf@rustcorp.com.au> <20111102233110.GA20289@redhat.com> <20111108214021.GA4538@redhat.com> <20111109195901.GA28155@redhat.com> <1320870287.3730.6.camel@lappy> <20111109205208.GA28599@redhat.com> <1320872248.3730.11.camel@lappy> <87aa83qoao.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Sasha Levin Cc: Krishna Kumar , kvm@vger.kernel.org, Pawel Moll , "Michael S. Tsirkin" , Alexey Kardashevskiy , Wang Sheng-Hui , lkml - Kernel Mailing List , virtualization@lists.linux-foundation.org, penberg@kernel.org, Christian Borntraeger , avi@redhat.com, Amit Shah List-Id: virtualization@lists.linuxfoundation.org T24gRnJpLCAxMSBOb3YgMjAxMSAwOTozOToxMyArMDIwMCwgU2FzaGEgTGV2aW4gPGxldmluc2Fz aGE5MjhAZ21haWwuY29tPiB3cm90ZToKPiBPbiBGcmksIE5vdiAxMSwgMjAxMSBhdCA2OjI0IEFN LCBSdXN0eSBSdXNzZWxsIDxydXN0eUBydXN0Y29ycC5jb20uYXU+IHdyb3RlOgo+ID4gKDIpIFRo ZXJlJ3Mgbm8gaHVnZSB3aW4gaW4ga2VlcGluZyB0aGUgc2FtZSBsYXlvdXQuIMKgTGV0J3MgbWFr ZSBzb21lCj4gPiDCoCDCoGNsZWFudXBzLiDCoFRoZXJlIGFyZSBtb3JlIHVzZXJzIGFoZWFkIG9m IHVzIHRoZW4gYmVoaW5kIHVzIChJCj4gPiDCoCDCoGhvcGUhKS4KPiAKPiBBY3R1YWxseSwgaWYg d2UgYWxyZWFkeSBkbyBjbGVhbnVwcywgaGVyZSBhcmUgdHdvIG1vcmUgc3VnZ2VzdGlvbnM6Cj4g Cj4gMS4gTWFrZSA2NGJpdCBmZWF0dXJlcyBhIG9uZSBiaWcgNjRiaXQgYmxvY2ssIGluc3RlYWQg b2YgaGF2aW5nIDMyYml0cwo+IGluIG9uZSBwbGFjZSBhbmQgMzIgaW4gYW5vdGhlci4KPiAyLiBS ZW1vdmUgdGhlIHJlc2VydmVkIGZpZWxkcyBvdXQgb2YgdGhlIGNvbmZpZyAodGhlIG9uZXMgdGhh dCB3ZXJlCj4gY2F1c2VkIGJ5IG1vdmluZyB0aGUgSVNSIGFuZCB0aGUgbm90aWZpY2F0aW9ucyBv dXQpLgoKWWVzLCB0aG9zZSB3ZXJlIGV4YWN0bHkgd2hhdCBJIHdhcyB0aGlua2luZy4gIEkgbGVm dCBpdCB2YWd1ZSBiZWNhdXNlCnRoZXJlIG1pZ2h0IGJlIG90aGVycyB5b3UgY2FuIHNlZSBpZiB3 ZSdyZSBwcmVwYXJlZCB0byBhYmFuZG9uIHRoZQpjdXJyZW50IGZvcm1hdC4KCkNoZWVycywKUnVz dHkuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1 YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0 aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5m by92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933010Ab1KPCfP (ORCPT ); Tue, 15 Nov 2011 21:35:15 -0500 Received: from ozlabs.org ([203.10.76.45]:39050 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756627Ab1KPCdJ convert rfc822-to-8bit (ORCPT ); Tue, 15 Nov 2011 21:33:09 -0500 From: Rusty Russell To: Sasha Levin Cc: "Michael S. Tsirkin" , lkml - Kernel Mailing List , Alexey Kardashevskiy , Amit Shah , Christian Borntraeger , Krishna Kumar , Pawel Moll , Wang Sheng-Hui , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, avi@redhat.com, penberg@kernel.org Subject: Re: [PATCHv2 RFC] virtio-spec: flexible configuration layout In-Reply-To: References: <87wrbkvh3v.fsf@rustcorp.com.au> <20111101114542.GA13434@redhat.com> <1320150813.3847.24.camel@lappy> <20111101124223.GA14060@redhat.com> <8739e7uy87.fsf@rustcorp.com.au> <20111102233110.GA20289@redhat.com> <20111108214021.GA4538@redhat.com> <20111109195901.GA28155@redhat.com> <1320870287.3730.6.camel@lappy> <20111109205208.GA28599@redhat.com> <1320872248.3730.11.camel@lappy> <87aa83qoao.fsf@rustcorp.com.au> User-Agent: Notmuch/0.6.1-1 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) Date: Wed, 16 Nov 2011 10:28:52 +1030 Message-ID: <87aa7xos3n.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Nov 2011 09:39:13 +0200, Sasha Levin wrote: > On Fri, Nov 11, 2011 at 6:24 AM, Rusty Russell wrote: > > (2) There's no huge win in keeping the same layout.  Let's make some > >    cleanups.  There are more users ahead of us then behind us (I > >    hope!). > > Actually, if we already do cleanups, here are two more suggestions: > > 1. Make 64bit features a one big 64bit block, instead of having 32bits > in one place and 32 in another. > 2. Remove the reserved fields out of the config (the ones that were > caused by moving the ISR and the notifications out). Yes, those were exactly what I was thinking. I left it vague because there might be others you can see if we're prepared to abandon the current format. Cheers, Rusty.