From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjTLK-0007TF-OC for qemu-devel@nongnu.org; Wed, 20 Jul 2011 05:45:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjTLG-00077i-2X for qemu-devel@nongnu.org; Wed, 20 Jul 2011 05:45:26 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:34872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjTLF-00075P-35 for qemu-devel@nongnu.org; Wed, 20 Jul 2011 05:45:21 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p6K9KkYh028015 for ; Wed, 20 Jul 2011 05:20:46 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p6K9ir6p087346 for ; Wed, 20 Jul 2011 05:44:53 -0400 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p6K3iqwW003357 for ; Tue, 19 Jul 2011 21:44:52 -0600 From: "Aneesh Kumar K.V" In-Reply-To: <1311143248-29509-1-git-send-email-weil@mail.berlios.de> References: <1311143248-29509-1-git-send-email-weil@mail.berlios.de> Date: Wed, 20 Jul 2011 15:14:26 +0530 Message-ID: <87aac9wakl.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix syntax error in debug code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , qemu-devel@nongnu.org On Wed, 20 Jul 2011 08:27:28 +0200, Stefan Weil wrote: > This error was reported by cppcheck: > > qemu/hw/9pfs/virtio-9p-debug.c:342: > error: Invalid number of character ({) when these macros are defined: > 'DEBUG_DATA'. > > Cc: Aneesh Kumar K.V > Signed-off-by: Stefan Weil > --- > hw/9pfs/virtio-9p-debug.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/9pfs/virtio-9p-debug.c b/hw/9pfs/virtio-9p-debug.c > index 4636ad5..96925f0 100644 > --- a/hw/9pfs/virtio-9p-debug.c > +++ b/hw/9pfs/virtio-9p-debug.c > @@ -295,7 +295,7 @@ static void pprint_data(V9fsPDU *pdu, int rx, size_t *offsetp, const char *name) > > if (rx) { > count = pdu->elem.in_num; > - } else > + } else { > count = pdu->elem.out_num; > } > Applied. We also need to update virtio-9p-debug w.r.t the new co-routine series. With co-routine we can have multiple 9p handler started simultaneously. -aneesh