From: Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>
To: shubhrajyoti-l0cyMroinI0@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
andy.green-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] OMAP4: I2C: correct the SYSC register offset for OMAP4
Date: Mon, 20 Jun 2011 08:39:10 -0700 [thread overview]
Message-ID: <87aadc8qcg.fsf@ti.com> (raw)
In-Reply-To: <1308561956-25103-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> (shubhrajyoti-l0cyMroinI0@public.gmane.org's message of "Mon, 20 Jun 2011 14:55:56 +0530")
shubhrajyoti-l0cyMroinI0@public.gmane.org writes:
> From: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
>
> The sysc offset is erroneous correct the offset.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
Actally, a better fix for this problem is to completely remove SYSC
register accesses for OMAP3+ platforms. This is handled already at the
hwmod layer.
Also, please Cc linux-omap for OMAP changes.
Kevin
> ---
> drivers/i2c/busses/i2c-omap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index d53cd61..cccec28 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -236,7 +236,7 @@ const static u8 reg_map_ip_v2[] = {
> [OMAP_I2C_BUF_REG] = 0x94,
> [OMAP_I2C_CNT_REG] = 0x98,
> [OMAP_I2C_DATA_REG] = 0x9c,
> - [OMAP_I2C_SYSC_REG] = 0x20,
> + [OMAP_I2C_SYSC_REG] = 0x10,
> [OMAP_I2C_CON_REG] = 0xa4,
> [OMAP_I2C_OA_REG] = 0xa8,
> [OMAP_I2C_SA_REG] = 0xac,
next prev parent reply other threads:[~2011-06-20 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 9:25 [PATCH] OMAP4: I2C: correct the SYSC register offset for OMAP4 shubhrajyoti-l0cyMroinI0
[not found] ` <1308561956-25103-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2011-06-20 15:39 ` Kevin Hilman [this message]
[not found] ` <87aadc8qcg.fsf-l0cyMroinI0@public.gmane.org>
2011-06-20 15:51 ` Shubhrajyoti
[not found] ` <4DFF6C93.7090605-l0cyMroinI0@public.gmane.org>
2011-06-20 16:15 ` Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aadc8qcg.fsf@ti.com \
--to=khilman-l0cymroini0@public.gmane.org \
--cc=andy.green-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shubhrajyoti-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.