diff for duplicates of <87aaf3g2sd.fsf@ti.com> diff --git a/a/1.txt b/N1/1.txt index a59906b..5064776 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,9 @@ "Varadarajan, Charulatha" <charu@ti.com> writes: > On Sat, Apr 23, 2011 at 04:32, Kevin Hilman <khilman@ti.com> wrote: ->> Make _set_gpio_wakeup() generic by removing ifdefs. Code for the +>> Make _set_gpio_wakeup() generic by removing ifdefs. ?Code for the >> various SoCs/bank-methods was already the same, except for the ->> non-wakeup GPIO checking. But that flag is set on a per-SoC basis, so +>> non-wakeup GPIO checking. ?But that flag is set on a per-SoC basis, so >> can be used for all SoCs. >> >> While here, use pr_err() and remove GPIO bank calculation assumption @@ -14,18 +14,14 @@ [...] >> -#endif ->> - default: ->> - printk(KERN_ERR "Can't enable GPIO wakeup for method %i\n", ->> - bank->method); ->> + if (bank->non_wakeup_gpios & gpio_bit) { ->> + pr_err("Unable to modify wakeup on non-wakeup GPIO%d\n", gpio); +>> - ? ? ? default: +>> - ? ? ? ? ? ? ? printk(KERN_ERR "Can't enable GPIO wakeup for method %i\n", +>> - ? ? ? ? ? ? ? ? ? ? ?bank->method); +>> + ? ? ? if (bank->non_wakeup_gpios & gpio_bit) { +>> + ? ? ? ? ? ? ? pr_err("Unable to modify wakeup on non-wakeup GPIO%d\n", gpio); > > use dev_err instead. Agreed, thanks. Kevin --- -To unsubscribe from this list: send the line "unsubscribe linux-omap" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index b99b5d3..79bfd45 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,21 +1,18 @@ "ref\01303513327-14532-1-git-send-email-khilman@ti.com\0" "ref\01303513327-14532-14-git-send-email-khilman@ti.com\0" "ref\0BANLkTi=z3zk2E5Big5Ot-QXP86gBr=D53w@mail.gmail.com\0" - "From\0Kevin Hilman <khilman@ti.com>\0" - "Subject\0Re: [PATCH 13/15] OMAP: GPIO: cleanup _set_gpio_wakeup(), remove ifdefs\0" + "From\0khilman@ti.com (Kevin Hilman)\0" + "Subject\0[PATCH 13/15] OMAP: GPIO: cleanup _set_gpio_wakeup(), remove ifdefs\0" "Date\0Tue, 03 May 2011 09:35:46 -0700\0" - "To\0Varadarajan" - " Charulatha <charu@ti.com>\0" - "Cc\0linux-omap@vger.kernel.org" - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "\"Varadarajan, Charulatha\" <charu@ti.com> writes:\n" "\n" "> On Sat, Apr 23, 2011 at 04:32, Kevin Hilman <khilman@ti.com> wrote:\n" - ">> Make _set_gpio_wakeup() generic by removing ifdefs. \302\240Code for the\n" + ">> Make _set_gpio_wakeup() generic by removing ifdefs. ?Code for the\n" ">> various SoCs/bank-methods was already the same, except for the\n" - ">> non-wakeup GPIO checking. \302\240But that flag is set on a per-SoC basis, so\n" + ">> non-wakeup GPIO checking. ?But that flag is set on a per-SoC basis, so\n" ">> can be used for all SoCs.\n" ">>\n" ">> While here, use pr_err() and remove GPIO bank calculation assumption\n" @@ -26,20 +23,16 @@ "[...]\n" "\n" ">> -#endif\n" - ">> - \302\240 \302\240 \302\240 default:\n" - ">> - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 printk(KERN_ERR \"Can't enable GPIO wakeup for method %i\\n\",\n" - ">> - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240bank->method);\n" - ">> + \302\240 \302\240 \302\240 if (bank->non_wakeup_gpios & gpio_bit) {\n" - ">> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 pr_err(\"Unable to modify wakeup on non-wakeup GPIO%d\\n\", gpio);\n" + ">> - ? ? ? default:\n" + ">> - ? ? ? ? ? ? ? printk(KERN_ERR \"Can't enable GPIO wakeup for method %i\\n\",\n" + ">> - ? ? ? ? ? ? ? ? ? ? ?bank->method);\n" + ">> + ? ? ? if (bank->non_wakeup_gpios & gpio_bit) {\n" + ">> + ? ? ? ? ? ? ? pr_err(\"Unable to modify wakeup on non-wakeup GPIO%d\\n\", gpio);\n" ">\n" "> use dev_err instead.\n" "\n" "Agreed, thanks.\n" "\n" - "Kevin\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Kevin -55cb2f435f16c31915a636d7fc3846841fb63358fd07306607dcc40e2c9fe9f6 +19603207463511daf2758ba72e8cfe014fc9a198467f6bbce3bef9e48c5b7074
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.