From: Kevin Hilman <khilman@ti.com>
To: Peter Barada <peter.barada@logicpd.com>
Cc: Peter Barada <peter.barada@gmail.com>,
Linux OMAP list <linux-omap@vger.kernel.org>
Subject: Re: Question regarding suspend/resume
Date: Mon, 04 Apr 2011 08:12:52 -0700 [thread overview]
Message-ID: <87aag6caob.fsf@ti.com> (raw)
In-Reply-To: <4D99D841.9040501@logicpd.com> (Peter Barada's message of "Mon, 04 Apr 2011 10:40:01 -0400")
Peter Barada <peter.barada@logicpd.com> writes:
[...]
>> What I can say based on the register dump you shared is that there is no
>> obvious driver issue going on where a clock was left on by a driver.
>>
>> More than likely what is going on is that the booloader is using a
>> device (e.g. USB, MMC) but is leaving it in a state such that that IP
>> block cannot idle, so the CORE powerdomain then does not fully idle.
>> In older kernels like this one, the linux drivers did not fully reset
>> the hardware so bootloaders could cause problems like this (the u-boot
>> on beagle has had several problems like this.)
>
> How can I determine if an IP block is not idled? Any suggestion where
> to add code into the suspend patch to do such a check?
>
Unfortunatly, there is no easy way for OMAP3-based platforms. There are
unfortunately several things that can be (mis)configured such that an IP
block will not properly idle. This is one of the reasons that
omap_hwmod was introduced. It gives a uniform way for IP blocks to be
enabled, idled and shutdown so they are in an a known state.
>> As a first whack at things, I would focus on USB OTG and MMC, as I've
>> seen problem with both on other platforms, like Beagle. You need to
>> ensure that both the these modules are fully reset either by the
>> bootloader when it's done using them, or by the kernel in the early boot
>> process. Current kernels now do the latter.
>
> Hmm, where in the current kernel is this done, device driver probe
> functions or common platform init code?
>
As part of the initializion of omap_hwmod for a given IP block, the
module is reset.
Kevin
prev parent reply other threads:[~2011-04-04 15:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 19:25 Question regarding suspend/resume Peter Barada
2011-03-15 20:11 ` Kevin Hilman
2011-03-31 20:17 ` Peter Barada
2011-03-31 20:48 ` Kevin Hilman
2011-04-01 5:05 ` Hiremath, Vaibhav
2011-04-04 14:31 ` Peter Barada
2011-04-04 15:26 ` Hiremath, Vaibhav
2011-04-04 14:40 ` Peter Barada
2011-04-04 15:12 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aag6caob.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.barada@gmail.com \
--cc=peter.barada@logicpd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.