From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v7 11/12] davinci: add tnetv107x evm backlight device Date: Fri, 10 Dec 2010 08:56:28 -0800 Message-ID: <87aakdd0sj.fsf@deeprootsystems.com> References: <1291733522-3626-1-git-send-email-cyril@ti.com> <1291733522-3626-12-git-send-email-cyril@ti.com> <4D00EEA1.8070201@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org" , "dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" , "linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org" , "grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org" , "rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" , "alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org" , "lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org" To: "Nori, Sekhar" Return-path: In-Reply-To: (Sekhar Nori's message of "Fri, 10 Dec 2010 21:31:59 +0530") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org Errors-To: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org List-Id: linux-spi.vger.kernel.org "Nori, Sekhar" writes: > On Thu, Dec 09, 2010 at 20:28:41, Chemparathy, Cyril wrote: >> On 12/09/2010 06:00 AM, Nori, Sekhar wrote: >> > On Thu, Dec 09, 2010 at 14:25:49, Nori, Sekhar wrote: >> > >> >> This call should simply return if machine is not tnetv107x EVM. >> >> >> >> I didn't follow the entire series but wondering why >> >> platform device registration should be a late init call. >> >> Typically the driver probe can be made a late init call >> >> in case of init sequence dependencies. >> > >> > I meant driver init, not probe. >> >> This was done to handle driver dependencies, and is meant to be >> temporary (until a real driver dependency framework comes in). >> >> Please see [1] for a bit more of background on changing drivers to use >> module_init(). > > Hmm, okay. Please include a check for machine in that case. > Sekhar is right. Today, we don't (can't) build this machine with others for a couple reasons, but we're moving towards removing those restrictions, so when this machine is included in a binary with others, it needs to check. Thanks, Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@deeprootsystems.com (Kevin Hilman) Date: Fri, 10 Dec 2010 08:56:28 -0800 Subject: [PATCH v7 11/12] davinci: add tnetv107x evm backlight device In-Reply-To: (Sekhar Nori's message of "Fri, 10 Dec 2010 21:31:59 +0530") References: <1291733522-3626-1-git-send-email-cyril@ti.com> <1291733522-3626-12-git-send-email-cyril@ti.com> <4D00EEA1.8070201@ti.com> Message-ID: <87aakdd0sj.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org "Nori, Sekhar" writes: > On Thu, Dec 09, 2010 at 20:28:41, Chemparathy, Cyril wrote: >> On 12/09/2010 06:00 AM, Nori, Sekhar wrote: >> > On Thu, Dec 09, 2010 at 14:25:49, Nori, Sekhar wrote: >> > >> >> This call should simply return if machine is not tnetv107x EVM. >> >> >> >> I didn't follow the entire series but wondering why >> >> platform device registration should be a late init call. >> >> Typically the driver probe can be made a late init call >> >> in case of init sequence dependencies. >> > >> > I meant driver init, not probe. >> >> This was done to handle driver dependencies, and is meant to be >> temporary (until a real driver dependency framework comes in). >> >> Please see [1] for a bit more of background on changing drivers to use >> module_init(). > > Hmm, okay. Please include a check for machine in that case. > Sekhar is right. Today, we don't (can't) build this machine with others for a couple reasons, but we're moving towards removing those restrictions, so when this machine is included in a binary with others, it needs to check. Thanks, Kevin