From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 29 Jun 2010 22:17:06 +0200 (CEST) Received: from arkanian.console-pimps.org ([212.110.184.194]:34148 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1491158Ab0F2URB (ORCPT ); Tue, 29 Jun 2010 22:17:01 +0200 Received: from localhost (cpc5-brad6-0-0-cust25.barn.cable.virginmedia.com [82.38.64.26]) by arkanian.console-pimps.org (Postfix) with ESMTPSA id 6CCD348043; Tue, 29 Jun 2010 21:17:00 +0100 (BST) From: Matt Fleming To: Lars-Peter Clausen Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen , Andrew Morton , linux-mmc@vger.kernel.org, Ralf Baechle Subject: Re: [PATCH v3] MMC: Add JZ4740 mmc driver In-Reply-To: <1277688041-23522-1-git-send-email-lars@metafoo.de> References: <1276924111-11158-19-git-send-email-lars@metafoo.de> <1277688041-23522-1-git-send-email-lars@metafoo.de> User-Agent: Notmuch/0.3.1-61-g3f63bb6 (http://notmuchmail.org) Emacs/23.1.90.2 (x86_64-unknown-linux-gnu) Date: Tue, 29 Jun 2010 21:17:00 +0100 Message-ID: <87aaqd1tmr.fsf@linux-g6p1.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-archive-position: 27277 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: matt@console-pimps.org Precedence: bulk X-list: linux-mips Return-Path: X-Keywords: X-UID: 19722 On Mon, 28 Jun 2010 03:20:41 +0200, Lars-Peter Clausen wrote: > This patch adds support for the mmc controller on JZ4740 SoCs. > > Signed-off-by: Lars-Peter Clausen > Cc: Andrew Morton > Cc: Matt Fleming > Cc: linux-mmc@vger.kernel.org > > --- > Changes since v1 > - Do not request IRQ with IRQF_DISABLED since it is a noop now > - Use a generous slack for the timeout timer. It does not need to be accurate. > Changes since v2 > - Use sg_mapping_to iterate over sg elements in mmc read and write functions > - Use bitops instead of a spinlock and a variable for testing whether a request > has been finished. > - Rework irq and timeout handling in order to get rid of locking in hot paths Acked-by: Matt Fleming Are you planning on maintaining this driver? If so, it'd be a good idea to update MAINTAINERS. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from arkanian.console-pimps.org ([212.110.184.194]:34148 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1491158Ab0F2URB (ORCPT ); Tue, 29 Jun 2010 22:17:01 +0200 From: Matt Fleming Subject: Re: [PATCH v3] MMC: Add JZ4740 mmc driver In-Reply-To: <1277688041-23522-1-git-send-email-lars@metafoo.de> References: <1276924111-11158-19-git-send-email-lars@metafoo.de> <1277688041-23522-1-git-send-email-lars@metafoo.de> Date: Tue, 29 Jun 2010 21:17:00 +0100 Message-ID: <87aaqd1tmr.fsf@linux-g6p1.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org Return-Path: To: Lars-Peter Clausen Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-mmc@vger.kernel.org, Ralf Baechle Message-ID: <20100629201700.qdA2WGMtTytzvbyB3R_AClvjdCx0_1kHOrvFqoA0ZZM@z> On Mon, 28 Jun 2010 03:20:41 +0200, Lars-Peter Clausen wrote: > This patch adds support for the mmc controller on JZ4740 SoCs. > > Signed-off-by: Lars-Peter Clausen > Cc: Andrew Morton > Cc: Matt Fleming > Cc: linux-mmc@vger.kernel.org > > --- > Changes since v1 > - Do not request IRQ with IRQF_DISABLED since it is a noop now > - Use a generous slack for the timeout timer. It does not need to be accurate. > Changes since v2 > - Use sg_mapping_to iterate over sg elements in mmc read and write functions > - Use bitops instead of a spinlock and a variable for testing whether a request > has been finished. > - Rework irq and timeout handling in order to get rid of locking in hot paths Acked-by: Matt Fleming Are you planning on maintaining this driver? If so, it'd be a good idea to update MAINTAINERS. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v3] MMC: Add JZ4740 mmc driver Date: Tue, 29 Jun 2010 21:17:00 +0100 Message-ID: <87aaqd1tmr.fsf@linux-g6p1.site> References: <1276924111-11158-19-git-send-email-lars@metafoo.de> <1277688041-23522-1-git-send-email-lars@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from arkanian.console-pimps.org ([212.110.184.194]:37272 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750699Ab0F2URD (ORCPT ); Tue, 29 Jun 2010 16:17:03 -0400 In-Reply-To: <1277688041-23522-1-git-send-email-lars@metafoo.de> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen , Andrew Morton , linux-mmc@vger.kernel.org, Ralf Baechle On Mon, 28 Jun 2010 03:20:41 +0200, Lars-Peter Clausen wrote: > This patch adds support for the mmc controller on JZ4740 SoCs. > > Signed-off-by: Lars-Peter Clausen > Cc: Andrew Morton > Cc: Matt Fleming > Cc: linux-mmc@vger.kernel.org > > --- > Changes since v1 > - Do not request IRQ with IRQF_DISABLED since it is a noop now > - Use a generous slack for the timeout timer. It does not need to be accurate. > Changes since v2 > - Use sg_mapping_to iterate over sg elements in mmc read and write functions > - Use bitops instead of a spinlock and a variable for testing whether a request > has been finished. > - Rework irq and timeout handling in order to get rid of locking in hot paths Acked-by: Matt Fleming Are you planning on maintaining this driver? If so, it'd be a good idea to update MAINTAINERS.