Re: [PM-SR] [PATCH] OMAP: PM: Remove the usage of vdd id's.

[Kevin Hilman <khilman@deeprootsystems.com>]

Thara Gopinath <thara@ti.com> writes:

> This patch removes the usage of vdd and sr id alltogether.
> This is achieved by introducing a separte voltage domain per
> VDD and hooking this up with the voltage and smartreflex
> internal info structure. Any user of voltage or smartreflex layer
> should call into omap_volt_domain_get to get the voltage
> domain handle and make use of this to call into the various
> exported API's.
>
> These changes should be part of V2 of the sr/voltage series
> instead of being a separate patch in itself.
>
> Signed-off-by: Thara Gopinath <thara@ti.com>

[...]

> -static struct omap_sr *_sr_lookup(int srid)
> +static struct omap_sr *_sr_lookup(struct omap_volt_domain *volt_domain)
>  {
>  	struct omap_sr *sr_info, *temp_sr_info;
>  
>  	sr_info = NULL;
>  	list_for_each_entry(temp_sr_info, &sr_list, node) {
> -		if (srid == temp_sr_info->srid) {
> +		if (volt_domain == temp_sr_info->volt_domain) {
>  			sr_info = temp_sr_info;
>  			break;

Do we still need an _sr_lookup() function?  Isn't there a single SR
instance per voltage domain?

At init time, the sr_info should be linked to the voltage domain, and
then the code can simply do:

    struct omap_sr *sr_info = voltdm->sr_info;

instead of _sr_lookup.

Kevin