From mboxrd@z Thu Jan 1 00:00:00 1970 From: Francisco Jerez Subject: Re: [PATCH] renouveau/nv10: remove duplicate vertex buffer registers Date: Mon, 01 Mar 2010 22:42:18 +0100 Message-ID: <87aaurk9c5.fsf@riseup.net> References: <1267211574-2443-1-git-send-email-luca@luca-barbieri.com> <87wrxwn7uc.fsf@riseup.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1972011148==" Return-path: In-Reply-To: (Luca Barbieri's message of "Mon, 1 Mar 2010 14:18:04 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Luca Barbieri Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org --===============1972011148== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Luca Barbieri writes: > On Mon, Mar 1, 2010 at 2:34 AM, Francisco Jerez wrote: >> Luca Barbieri writes: >> >>> NV10TCL defines the vertex buffer registers both as arrays and as >>> individual named registers. >>> >>> This causes duplicate register definitions and the individual registers >>> are not used either by the DDX or by the Mesa driver. >>> >>> Francisco Jerez said to remove them all. >>> >> I forgot to ask: why do they bother you? > > I am experimenting with rewriting renouveau-gen.c in Python, and > stored registers in a dictionary with the register offset as key. > > Having multiple registers at the same offset obviously causes issues > with that, and this is the only instance of that problem, so it seems > better to remove it than adding complexity to tools to handle it. Fair enough, commited. --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkuMNLoACgkQ196Zy2qEI5fpbQCfaDK9KW5RqV+YuD33xTt9fu54 ogAAniY5xARfKSV9vHaajUQZP6lwGl0/ =VOWa -----END PGP SIGNATURE----- --==-=-=-- --===============1972011148== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Nouveau mailing list Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org http://lists.freedesktop.org/mailman/listinfo/nouveau --===============1972011148==--