From: Kalle Valo <kalle.valo@iki.fi>
To: Rafael Laufer <rlaufer@CS.UCLA.EDU>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
"Gábor Stefanik" <netrolller.3d@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Implementation of the IEEE80211_RADIOTAP_RATE option
Date: Sun, 23 Aug 2009 11:06:26 +0300 [thread overview]
Message-ID: <87ab1rt0n1.fsf@litku.valot.fi> (raw)
In-Reply-To: <4A906B4C.6010208@cs.ucla.edu> (Rafael Laufer's message of "Sat\, 22 Aug 2009 15\:03\:56 -0700")
Rafael Laufer <rlaufer@CS.UCLA.EDU> writes:
>>> + /* Get the rate parameter from the radiotap header, +
>>> * allowing rate selection on a per-packet basis + */
>>>
>>
>> coding style
>>
>
> I am a newbie, I am gonna look into the coding style,
In case you didn't know, Documentation/CodingStyle is the file you want
to need.
> but I assume you are talking about the missing blank line in the
> beginning
I think Johannes' means the comment style:
/*
* The prefer multiline comments to look like this. blah blah blah blah
* blah blah blah blah blah blah blah blah blah blah blah blah
*/
--
Kalle Valo
next prev parent reply other threads:[~2009-08-23 8:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 0:40 [PATCH] Implementation of the IEEE80211_RADIOTAP_RATE option Rafael Laufer
2009-08-21 8:18 ` Johannes Berg
2009-08-21 13:30 ` Gábor Stefanik
2009-08-21 18:03 ` Rafael Laufer
2009-08-21 18:52 ` Gábor Stefanik
2009-08-21 19:06 ` Rafael Laufer
2009-08-21 19:57 ` Gábor Stefanik
2009-08-21 20:21 ` Rafael Laufer
2009-08-21 20:24 ` Rafael Laufer
2009-08-22 7:50 ` Johannes Berg
2009-08-22 22:05 ` Rafael Laufer
2009-08-22 7:48 ` Johannes Berg
2009-08-22 22:03 ` Rafael Laufer
2009-08-23 8:06 ` Kalle Valo [this message]
2009-08-23 9:11 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ab1rt0n1.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netrolller.3d@gmail.com \
--cc=rlaufer@CS.UCLA.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.