From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLj0N-0000NR-GI for qemu-devel@nongnu.org; Tue, 30 Jun 2009 15:28:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLj0I-0000Mi-R8 for qemu-devel@nongnu.org; Tue, 30 Jun 2009 15:28:34 -0400 Received: from [199.232.76.173] (port=44011 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLj0I-0000Mf-LV for qemu-devel@nongnu.org; Tue, 30 Jun 2009 15:28:30 -0400 Received: from mx2.redhat.com ([66.187.237.31]:35359) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MLj0I-0006SD-9J for qemu-devel@nongnu.org; Tue, 30 Jun 2009 15:28:30 -0400 Subject: Re: [Qemu-devel] [PATCH 4/8] qdev/core: bus list References: <1246353962-32308-1-git-send-email-kraxel@redhat.com> <200906301218.35086.paul@codesourcery.com> <87k52t8xvk.fsf@pike.pond.sub.org> <200906301821.18245.paul@codesourcery.com> From: Markus Armbruster Date: Tue, 30 Jun 2009 21:26:26 +0200 In-Reply-To: <200906301821.18245.paul@codesourcery.com> (Paul Brook's message of "Tue\, 30 Jun 2009 18\:21\:17 +0100") Message-ID: <87ab3p7cbh.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org, Gerd Hoffmann Paul Brook writes: > On Tuesday 30 June 2009, Markus Armbruster wrote: >> Paul Brook writes: >> > On Tuesday 30 June 2009, Gerd Hoffmann wrote: >> >> * maintain a list of busses. >> >> * maintain bus numbers. >> >> * add function to find busses by type / name / number. >> >> * add monitor command to list busses. >> > >> > I still object to this patch. Busses should be identified by their >> > location in the tree, not by number. >> > >> > Paul >> >> Location in the tree can be uniquely identified by a number. Handy when >> all you want is enumerate the buses, and you don't really care where >> they're hanging out in the tree. Why should something like that not be >> done? > > The address of the BusState is also a locally unique identifier. That doesn't > mean it's a good thing to expose to the user. > > Paul Red herring.