From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Reddy, Teerth" <teerth@ti.com>, Rajendra Nayak <rnayak@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 00/08] OMAP3: SR: Fixes in Smartreflex driver - Resending
Date: Tue, 24 Mar 2009 09:13:16 -0700 [thread overview]
Message-ID: <87ab7a292b.fsf@deeprootsystems.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB02FAFEE9A9@dbde02.ent.ti.com> (Teerth Reddy's message of "Tue\, 24 Mar 2009 16\:22\:05 +0530")
"Reddy, Teerth" <teerth@ti.com> writes:
> Resending the patches sent by Rajendra after fixing Kevin's comments and cleanup.
>
> This series fixes a set of defects/issues in Smartreflex driver. SR autocompensation is now functional and is validated with these patches on a ES3.1 based SDP with the N values in Efuse.
>
> Patches apply on top of the pm-2.6.28 branch from Kevin's pm tree.
> git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
>
This series doesn't compile unless SRF is enabled which after a little
more digging makes me see that SmartReflex is not pretty tightly
coupled to SRF.
I don't think SmartReflex support need to be dependent on SRF? It
seems like the resource_get_level() calls should be replaced by OMAP
PM layer calls. In particular, resource_get_level("vdd_opp1") could
be replaced by omap_pm_dsp_get_opp() etc.
Also, one more nitpick about cleanup while we're at it:
Can you convert all the bit defines (0x1 << n) into BIT(n)
Kevin
prev parent reply other threads:[~2009-03-24 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 10:52 [PATCH 00/08] OMAP3: SR: Fixes in Smartreflex driver - Resending Reddy, Teerth
2009-03-24 16:13 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ab7a292b.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=teerth@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.