From: Andi Kleen <andi@firstfloor.org>
To: David John <davidjon@xenontk.org>
Cc: mingo@elte.hu, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
venkatesh.pallipadi@intel.com, tglx@linutronix.de
Subject: Re: [PATCH v5] HPET: Remove the BKL.
Date: Tue, 21 Oct 2008 19:35:26 +0200 [thread overview]
Message-ID: <87abcxetr5.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1224568707-2361-1-git-send-email-davidjon@xenontk.org> (David John's message of "Tue, 21 Oct 2008 11:28:27 +0530")
David John <davidjon@xenontk.org> writes:
> switch (cmd) {
> case HPET_IE_OFF:
> - if ((devp->hd_flags & HPET_IE) == 0)
> + spin_lock_irq(&hpet_lock);
> + if ((devp->hd_flags & HPET_IE) == 0) {
> + spin_unlock_irq(&hpet_lock);
> break;
Reads don't need to be locked here, so you could just move the spin_lock_irq
down a bit and avoid the redundant unlock_irq. Same below.
> + }
-Andi
--
ak@linux.intel.com
prev parent reply other threads:[~2008-10-21 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 5:58 [PATCH v5] HPET: Remove the BKL David John
2008-10-21 11:34 ` Ingo Molnar
2008-10-21 11:52 ` David John
2008-10-21 17:35 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87abcxetr5.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davidjon@xenontk.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.