All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@nokia.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, John Linville <linville@tuxdriver.com>
Subject: Re: stlc45xx: mac80211 driver for N800 and N810
Date: Sat, 20 Sep 2008 11:16:51 +0300	[thread overview]
Message-ID: <87abe3mdu4.fsf@nokia.com> (raw)
In-Reply-To: <1221819119.10419.75.camel@johannes.berg> (ext Johannes Berg's message of "Fri\, 19 Sep 2008 12\:11\:59 +0200")

Johannes Berg <johannes@sipsolutions.net> writes:

> On Fri, 2008-09-19 at 07:43 +0300, Kalle Valo wrote:
>> Hello all,
>> 
>> Nokia yesterday published stlc45xx, which is a mac80211 driver for
>> N800 and N810. Webpage here:
>> 
>> http://stlc45xx.garage.maemo.org/
>
> quick look at the code

Thanks a lot! I didn't send any code for review yet because, as you
noticed, the code is in early stages still. I will go through your
comments next week and fix them.

> Overall looks pretty good, I'm concerned that the binary helper is
> _required_, we had this with ipw3945 and it wasn't accepted. Any way to
> make it not required?

I guess I'll have to find a way. Maybe have very convervative default
values in the driver which the binary tool can update? That way the
driver would work without stlc45xx-cal (with the cost of worse
performance) and still our requirements would be fulfilled.

-- 
Kalle Valo

  reply	other threads:[~2008-09-20  8:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-19  4:43 stlc45xx: mac80211 driver for N800 and N810 Kalle Valo
2008-09-19  5:57 ` Luis R. Rodriguez
2008-09-19  8:59   ` Johannes Berg
2008-09-19 14:58     ` Christian Lamparter
2008-09-19 17:55       ` Luis R. Rodriguez
2008-09-22  8:06         ` Kalle Valo
2008-09-22 11:22           ` Chr
2008-09-22 11:33             ` Kalle Valo
2008-09-19  8:58 ` Johannes Berg
2008-09-19 10:11 ` Johannes Berg
2008-09-20  8:16   ` Kalle Valo [this message]
2008-09-20 21:09     ` Luis R. Rodriguez
2008-09-22 10:37       ` Kalle Valo
2008-09-26 19:37     ` Johannes Berg
2008-12-05 19:20   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87abe3mdu4.fsf@nokia.com \
    --to=kalle.valo@nokia.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.