From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KaWG2-0002Fm-5D for mharc-grub-devel@gnu.org; Tue, 02 Sep 2008 09:49:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KaWG0-0002Fb-Oc for grub-devel@gnu.org; Tue, 02 Sep 2008 09:49:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KaWFz-0002FJ-DO for grub-devel@gnu.org; Tue, 02 Sep 2008 09:49:20 -0400 Received: from [199.232.76.173] (port=51645 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaWFz-0002FG-7X for grub-devel@gnu.org; Tue, 02 Sep 2008 09:49:19 -0400 Received: from smtp-vbr15.xs4all.nl ([194.109.24.35]:1425) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KaWFz-0005v8-2F for grub-devel@gnu.org; Tue, 02 Sep 2008 09:49:19 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr15.xs4all.nl (8.13.8/8.13.8) with ESMTP id m82DnBmB035884 for ; Tue, 2 Sep 2008 15:49:12 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080830122626.GA5899@thorin> <20080830114118.3zltziz18g0ss8ws-cebfxv@webmail.spamcop.net> <20080831133355.GC2688@thorin> <1220312369.21219.18.camel@dv> <20080902134045.GB31165@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 02 Sep 2008 15:55:18 +0200 In-Reply-To: <20080902134045.GB31165@thorin> (Robert Millan's message of "Tue, 2 Sep 2008 15:40:45 +0200") Message-ID: <87abeqlkjd.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] fix disk->id abuse X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2008 13:49:21 -0000 [...] >> We could write a macro for ID comparison that would compare both the >> "driver ID" (disk->dev->id) and "device ID" (disk->id). In this case, >> we can omit disk->id initialization in the drivers supporting only one >> device (e.g. memdisk) and only leave it where it's indeed needed for >> identifying separate devices, thus removing potentially confusing code. > > Sounds fine, although what worries me most if the current usage of 'id' in > scsi.c, which can lead to collision already. > > I assume using LUNs is a proper solution for that one? No, it is not. I think I already said so on IRC? -- Marco