From mboxrd@z Thu Jan 1 00:00:00 1970 From: OGAWA Hirofumi Subject: Re: [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2) Date: Fri, 22 Aug 2008 23:49:07 +0900 Message-ID: <87abf5ayvw.fsf@devron.myhome.or.jp> References: <1218299181.26926.88.camel@pmac.infradead.org> <20080816190858.4d150ea1@mjolnir.drzeus.cx> <20080822092448.GC20055@kernel.dk> <20080822131314.23ba745a@mjolnir.drzeus.cx> <20080822112010.GJ20055@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pierre Ossman , linux-fsdevel@vger.kernel.org, David Woodhouse To: Jens Axboe Return-path: Received: from mail.parknet.ad.jp ([210.171.162.6]:44579 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbYHVOtM (ORCPT ); Fri, 22 Aug 2008 10:49:12 -0400 In-Reply-To: <20080822112010.GJ20055@kernel.dk> (Jens Axboe's message of "Fri, 22 Aug 2008 13:20:11 +0200") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jens Axboe writes: > On Fri, Aug 22 2008, Pierre Ossman wrote: >> On Fri, 22 Aug 2008 11:24:48 +0200 >> Jens Axboe wrote: >> >> > >> > I agree with that, the thought did cross my mind earlier as well. I >> > committed something like the below (in two patches). Do you want me to >> > queue up your mmc patches as well? >> > >> >> As it stands, no. If nobody can find a measurable improvement then this >> code is just more things that can go wrong. > > It could just be that the device you tested with doesn't do anything > with the discard information. But I agree, until there's a verified > benefit to adding the code, we can leave it be. That doesn't have improvement? E.g. it means the results dd if=/dev/zero of=/dev/xxx and ./discard_all /dev/xxx dd if=/dev/zero of=/dev/xxx are same? Or FAT doesn't have? -- OGAWA Hirofumi