From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1JHl8s-0005vT-6b
	for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 14:20:10 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JHl8p-0005ra-Ig
	for grub-devel@gnu.org; Wed, 23 Jan 2008 14:20:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JHl8k-0005gi-OA
	for grub-devel@gnu.org; Wed, 23 Jan 2008 14:20:06 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JHl8k-0005gQ-7v
	for grub-devel@gnu.org; Wed, 23 Jan 2008 14:20:02 -0500
Received: from smtp-vbr4.xs4all.nl ([194.109.24.24])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mgerards@xs4all.nl>) id 1JHl8k-0000wR-0J
	for grub-devel@gnu.org; Wed, 23 Jan 2008 14:20:02 -0500
Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net
	[145.99.174.249])
	by smtp-vbr4.xs4all.nl (8.13.8/8.13.8) with ESMTP id m0NJJvbr009639
	for <grub-devel@gnu.org>; Wed, 23 Jan 2008 20:20:01 +0100 (CET)
	(envelope-from mgerards@xs4all.nl)
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <20080119170105.GJ1341@kirkkit.kollasch.net>
	<fmtfdf$ano$1@ger.gmane.org>
	<ca0f59980801221058u7472148g236121871a0d40db@mail.gmail.com>
	<fn7p5q$77r$1@ger.gmane.org>
	<ca0f59980801230831y118c9064hb394f264d49509db@mail.gmail.com>
Mail-Copies-To: mgerards@xs4all.nl
Date: Wed, 23 Jan 2008 20:21:13 +0100
In-Reply-To: <ca0f59980801230831y118c9064hb394f264d49509db@mail.gmail.com>
	(bean123ch@gmail.com's message of "Thu, 24 Jan 2008 00:31:29 +0800")
Message-ID: <87abmwcpqu.fsf@xs4all.nl>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by XS4ALL Virus Scanner
X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9
Subject: Re: UFS (FFS) support seems broken in grub2
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2008 19:20:07 -0000

Bean <bean123ch@gmail.com> writes:

> On Jan 24, 2008 12:15 AM, walt <wa1ter@myrealbox.com> wrote:
>> Bean wrote:
>> > This patch should fix the problem...
>>
>> Yes, thanks!  I had to use the -l flag before patch would use it,
>> and even then the last hunk needed increased fuzz.
>>
>> Are you going to commit it today?
>
> thanks for the testing, if you have ufs2, please check it as well.

Hopefully it can be tested.

> this is the new patch after adding changelog:
>
>
> 	* fs/ufs.c (GRUB_UFS_MAX_VOLLEN) : New constant.

s/constant/macro/

VOLNAME_LEN would be better, I think

> 	(grub_ufs_sblock) : New member volume name.
> 	(grub_ufs_find_file) : Fix string copy bug.
> 	(grub_ufs_label) : Implement this function properly.

If you can make these changes, feel free to commit the patch.

--
Marco