From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IqVjm-0004ld-Nd for mharc-grub-devel@gnu.org; Fri, 09 Nov 2007 10:25:38 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IqVjk-0004iW-69 for grub-devel@gnu.org; Fri, 09 Nov 2007 10:25:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IqVjh-0004eq-Fv for grub-devel@gnu.org; Fri, 09 Nov 2007 10:25:35 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqVjh-0004ej-2y for grub-devel@gnu.org; Fri, 09 Nov 2007 10:25:33 -0500 Received: from smtp-vbr17.xs4all.nl ([194.109.24.37]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IqVjg-0005ks-JQ for grub-devel@gnu.org; Fri, 09 Nov 2007 10:25:32 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr17.xs4all.nl (8.13.8/8.13.8) with ESMTP id lA9FPUGf064069 for ; Fri, 9 Nov 2007 16:25:31 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <4730DDB8.4090902@nic.fi> <20071107201907.GB10337@thorin> <47322185.2040005@nic.fi> <20071107212832.GA17708@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 09 Nov 2007 16:26:02 +0100 In-Reply-To: <20071107212832.GA17708@thorin> (Robert Millan's message of "Wed, 7 Nov 2007 22:28:32 +0100") Message-ID: <87abpnl9th.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: grub2 ChangeLog term/i386/pc/serial.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2007 15:25:36 -0000 Robert Millan writes: > On Wed, Nov 07, 2007 at 10:35:17PM +0200, Vesa J=E4=E4skel=E4inen wrote: >> > grub_inb() and grub_outb() are based on the inb()/outb() implementation >> > from glibc headers, so I kept the same arguments for consistency. >>=20 >> I see... Once again inconsistency introduced by Unix folks... as AT&T >> assembler wouldn't be enough, they then poisons C libs too... oh well... >> another thing to try to keep in mind... > > I always thought the Right Way to do this would be implement it in GCC, > so that you can do things like: > > __some_magic__(PORT_ADDR) |=3D 0x80; > > which is much more beatufil than either of: > > outb (PORT_ADDR, inb (PORT_ADDR) | 0x80); > > outb (inb (PORT_ADDR) | 0x80, PORT_ADDR); > > don't you think? > > (now if someone is bored and takes my suggestion to gcc-patches, that'd m= ake > my day...) That's possible in C++ using operator overloading AFAIK. Did this commit fix serial support for LB? -- Marco