From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keita Maehara <maehara@debian.org>
Subject: Re: [PATCH 2/2] ac97: YMF743 missing controls support
Date: Wed, 19 Sep 2007 08:47:23 +0900
Message-ID: <87abrj1qpg.wl%maehara@debian.org>
References: <87r6kwotup.wl%maehara@debian.org> <s5hvea8rmdp.wl%tiwai@suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from cmta101.odn.ne.jp (mta101.odn.ne.jp [143.90.14.133])
	by alsa0.perex.cz (Postfix) with ESMTP id 8B03D24559
	for <alsa-devel@alsa-project.org>;
	Wed, 19 Sep 2007 01:46:02 +0200 (CEST)
Received: from vmta101.odn.ne.jp by cmta101.odn.ne.jp with ESMTP
	id <20070918234558015.MUND.24626.cmta101.odn.ne.jp@mta101.odn.ne.jp>
	for <alsa-devel@alsa-project.org>; Wed, 19 Sep 2007 08:45:58 +0900
Received: from emta101.odn.ne.jp by vmta101.odn.ne.jp with ESMTP
	id <20070918234557977.SJBA.10257.vmta101.odn.ne.jp@mta101.odn.ne.jp>
	for <alsa-devel@alsa-project.org>; Wed, 19 Sep 2007 08:45:57 +0900
Received: from sb83g5m.odn.ne.jp ([61.116.110.249] [61.116.110.249])
	by emta101.odn.ne.jp with ESMTP
	id <20070918234557911.OPKH.12658.emta101.odn.ne.jp@mta101.odn.ne.jp>
	for <alsa-devel@alsa-project.org>; Wed, 19 Sep 2007 08:45:57 +0900
In-Reply-To: <s5hvea8rmdp.wl%tiwai@suse.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Tue, 18 Sep 2007 18:04:02 +0200,
Takashi Iwai wrote:

> At Wed, 19 Sep 2007 00:50:54 +0900,
> Keita Maehara wrote:
> > 
> > From: Keita Maehara <maehara@debian.org>
> > 
> > These patches enable a few YMF743 controls (Tone/3D/IEC958) that won't
> > be detected with the current version of ALSA.
> > 
> > Signed-off-by: Keita Maehara <maehara@debian.org>
> 
> The changes look good to me, but I'd like to ask you to rewrite the
> patch to follow the standard coding style.  Yes, the original ac97
> code doesn't follow, but at least, we should do it right for the newly
> added/changed codes.  For example, keep lines within 80 chars, fold
> lines appropriately, avoid if ((err = ...)) style, etc.

I was wondering whether to follow the coding style for them indeed but
understood the policy now. Sorry to bother you.

> In doubt, you can run scripts/checkpatch.pl in the linux kernel tree.

Now they're checkpatch-clean anyway. I've put the second version at
http://people.debian.org/~maehara/alsa-ymf743.

-- 
Keita Maehara <maehara@debian.org>