From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1GXBNm-0000pT-K8 for mharc-grub-devel@gnu.org; Tue, 10 Oct 2006 02:46:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GXBNk-0000o9-Ae for grub-devel@gnu.org; Tue, 10 Oct 2006 02:46:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GXBNj-0000no-9l for grub-devel@gnu.org; Tue, 10 Oct 2006 02:46:27 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GXBNj-0000ni-4V for grub-devel@gnu.org; Tue, 10 Oct 2006 02:46:27 -0400 Received: from [194.109.24.34] (helo=smtp-vbr14.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GXBVR-0007rb-HQ for grub-devel@gnu.org; Tue, 10 Oct 2006 02:54:25 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr14.xs4all.nl (8.13.8/8.13.8) with ESMTP id k9A6kJPY067898; Tue, 10 Oct 2006 08:46:24 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1160447238.29722.4.camel@diesel> <1160454731.32244.6.camel@diesel> Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 10 Oct 2006 08:54:43 +0200 In-Reply-To: (Jeff Chua's message of "Tue, 10 Oct 2006 12:59:35 +0800 (SGT)") Message-ID: <87ac441wzw.fsf@xs4all.nl> User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner Cc: Jeff Chua Subject: Re: how to increase commandline size (patch + changelog) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2006 06:46:28 -0000 Jeff Chua writes: > On Mon, 9 Oct 2006, Hollis Blanchard wrote: > >>> Shall I use '#ifdef __linux__' to include only on linux, and >>> '#define COMMAND_LINE_SIZE 255' for non-linux system? >> > 5B> Well, does this number change often? If not, let's just copy it. >> >> If so, then we're screwed anyways because asm/param.h would only match >> the installed kernel's limit, so may not work for other kernel versions. > > You're right. asm/param.h determines the limit. We've read this from > here for linux. > > The idea is that there are users out there who wants to pass quite a > few parameters during boot, and loadlin currently handles this. I'm > passing network address, netmask, broadcast, hostname, modules_to_load > and boot the system up using ramdisk. This allow every system to be > unique and yet able to boot from the same CDROM/image. > > So, another approach is to use "configure --CommandLineSize=1024" to > specify the size, but I thought reading from asm/param.h would be > easier. I don't like limits that are introduced at compile time. It means that either things break when a kernel with other limits are used. Or that users will get binaries with limits (for example, when using a GRUB 2 package). -- Marco