From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EYojl-0001D2-2b for mharc-grub-devel@gnu.org; Sun, 06 Nov 2005 12:55:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EYoji-0001CK-62 for grub-devel@gnu.org; Sun, 06 Nov 2005 12:55:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EYojh-0001Bi-0j for grub-devel@gnu.org; Sun, 06 Nov 2005 12:55:21 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EYojg-0001Ba-RG for grub-devel@gnu.org; Sun, 06 Nov 2005 12:55:20 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EYojg-0004rx-Uh for grub-devel@gnu.org; Sun, 06 Nov 2005 12:55:21 -0500 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id EBF798346 for ; Sun, 6 Nov 2005 18:55:19 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 27529-06 for ; Sun, 6 Nov 2005 18:55:19 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 2EA70839B for ; Sun, 6 Nov 2005 18:55:19 +0100 (CET) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id E580CC045 for ; Sun, 6 Nov 2005 18:55:18 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <436CBF00.1060304@yahoo.fr> <200511051928.49549.okuji@enbug.org> <8d3e4fe8a4a23a5b220acab6fbca2bc2@penguinppc.org> From: Marco Gerards Date: Sun, 06 Nov 2005 18:55:25 +0100 In-Reply-To: <8d3e4fe8a4a23a5b220acab6fbca2bc2@penguinppc.org> (Hollis Blanchard's message of "Sat, 5 Nov 2005 15:12:03 -0600") Message-ID: <87acghzmnm.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: play.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Nov 2005 17:55:22 -0000 Hollis Blanchard writes: > On Nov 5, 2005, at 2:48 PM, Dennis Clarke wrote: > >> On 11/5/05, Yoshinori K. Okuji wrote: >>> On Saturday 05 November 2005 03:17 pm, Vincent Pelletier wrote: >>>> Here is the play command, along with some songs. >>> >>> I point out some stylish mistakes. >> >> Personally I was thrilled with the idea of sound and really, these >> little "style" things are so trivial. Its like someone hanging a >> painting and then commenting on color of the frame. >> >> Actually I am sure it is just a language barrier issue and what you >> meant to say was "wow, thanks for this cool submission!" > > Please don't confuse constructive criticism for disinterest or a lack > of appreciation. The way code approaches perfection is through peer > review, and you will notice that almost all patches from all > contributors are commented on. In fact, most people actively seek out > criticism for their patches! That is why Vincent posted it to the list > for comment rather than just committing it himself. The Hurd just works the other way around sometimes. People send in simple patches and they are ignored very often. There is nothing more frustrating than that. It might seem a bit harsh to get some critique on a patch, but it is the best in the long term for everyone. Which reminds me of all the patches for GRUB I still have to review... ;-/ -- Marco