From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1E4mV7-0000yw-QV for mharc-grub-devel@gnu.org; Mon, 15 Aug 2005 17:28:10 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E4mUz-0000ut-CY for grub-devel@gnu.org; Mon, 15 Aug 2005 17:28:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E4mUo-0000pd-NN for grub-devel@gnu.org; Mon, 15 Aug 2005 17:27:52 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E4mUo-0000oV-6b for grub-devel@gnu.org; Mon, 15 Aug 2005 17:27:50 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E4mdv-0000aW-Fg for grub-devel@gnu.org; Mon, 15 Aug 2005 17:37:15 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 4C48888E0 for ; Mon, 15 Aug 2005 23:21:23 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 31973-07 for ; Mon, 15 Aug 2005 23:21:20 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id A272D873F for ; Mon, 15 Aug 2005 23:21:20 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 5ABC0C045 for ; Mon, 15 Aug 2005 23:21:20 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <42FF3097.7030904@nic.fi> <87zmrjxge4.fsf@student.han.nl> <430103AD.1090800@nic.fi> From: Marco Gerards Date: Mon, 15 Aug 2005 23:21:26 +0200 In-Reply-To: <430103AD.1090800@nic.fi> ( =?iso-8859-1?q?Vesa_J=E4=E4skel=E4inen's_message_of?= "Tue, 16 Aug 2005 00:05:49 +0300") Message-ID: <87acjivquh.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: vesafb terminal for testing. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2005 21:28:06 -0000 Vesa J=E4=E4skel=E4inen writes: >> There are some long lines, can you please make them shorter so >> the maximal line length is 78 characters? > > Hmm... I made another scan for those. Still I left some of those there > because in my opinion it is much more readable in that way. But splitted > some lines. Can you should me which so I can come up with a suggestion? >> You sometimes use C++ style comments. Can you change your comments so >> they match the style described in the GCS: >> http://www.gnu.org/prep/standards/html_node/Comments.html#Comments > > I think there should not be anymore C++ style comments. It's hard to > stay away from ooooold habits :) > > Fortunely I found GNU indentation mode from my editor :)... It makes > this a bit easier. > > I will scan the code once more and then commit a bit different version > to CVS as Okuji asked to commit it to there for easier testing. Cool, fine for me. :) Thanks, Marco