From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1CI3pA-0002Dr-Av for mharc-grub-devel@gnu.org; Thu, 14 Oct 2004 07:31:12 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CI3p8-0002Di-QZ for grub-devel@gnu.org; Thu, 14 Oct 2004 07:31:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CI3p8-0002DT-86 for grub-devel@gnu.org; Thu, 14 Oct 2004 07:31:10 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CI3p8-0002DF-4A for grub-devel@gnu.org; Thu, 14 Oct 2004 07:31:10 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CI3hx-0001HF-GE for grub-devel@gnu.org; Thu, 14 Oct 2004 07:23:45 -0400 Received: from localhost (charlie.han.nl [145.74.66.9]) by mail-cn.han.nl (Postfix) with ESMTP id 184BD8E95 for ; Thu, 14 Oct 2004 13:23:44 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by localhost (charlie.han.nl [145.74.66.9]) (amavisd-new, port 10024) with ESMTP id 26105-04 for ; Thu, 14 Oct 2004 13:23:41 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id BF31D8D38 for ; Thu, 14 Oct 2004 13:23:40 +0200 (CEST) Received: from marco.marco-g.com (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 08B06C046 for ; Thu, 14 Oct 2004 13:23:38 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20041014033756.GA6157@miracle> From: Marco Gerards Date: Thu, 14 Oct 2004 11:23:33 +0000 In-Reply-To: <20041014033756.GA6157@miracle> (Hollis Blanchard's message of "Wed, 13 Oct 2004 22:37:56 -0500") Message-ID: <87acupk0ga.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new@vscan-cn.han.nl Subject: Re: [ppc patch] heap memory allocation X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Oct 2004 11:31:11 -0000 Hollis Blanchard writes: > Ok, this is much simpler than the last patch; it just changes which > hardcoded region of memory we use. These are the areas I think we > need to watch out for (from memory, so not authoritative): > > 0-16 KB exception handlers > 4-5 MB Old World Mac firmware > 8-? MB some older RS/6000 > 12-20 MB newer RS/6000 / pSeries > 20+-32 MB other bits on pSeries, like NVRAM > > Our link base was chosen at 2MB, which is working fine. This patch uses > all the memory from the exception handlers (which may or may not be > claimed by firmware) to the link base. That should give us plenty of > room for the GRUB heap, while also leaving as much as possible open for > the OSs to be loaded at. This is better then what is done now. > * kern/powerpc/ieee1275/init.c (grub_machine_init): Call > grub_console_init first. > Change the memory range used for grub_ieee1275_claim and > grub_mm_init_region. > Print an error message if the claim fails. You forgot to mention that grub/misc.h is included. Can you add "Include ." here? If you make the change that Johan mentioned, it can go in as far as I am concerned. Thanks, Marco