Re: [Buildroot] [PATCH] package/prboom: fix build with GCC 14

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Yegor" == Yegor Yefremov via buildroot <buildroot@buildroot.org> writes:

 > Since autoconf 2.73, AC_PROG_CC enables C23 with -std=gnu23 when the
 > compiler accepts it, which GCC 14 does. As prboom is autoreconfigured,
 > it is then built in C23 mode, where false and true are keywords:

 > ../../src/doomtype.h:48:15: error: expected identifier before 'false'
 >    48 | typedef enum {false, true} boolean;
 >       |               ^~~~~

 > Commit 2eb72e7666 ("package/prboom: fix build w/ gcc-15") already
 > forces -std=gnu18 to avoid this, but only for GCC >= 15, where C23 is
 > the default. Apply it from GCC 14 on. With -std=gnu18 in CFLAGS, the
 > configure C23 check fails and -std=gnu23 is no longer added.

 > This issue has been present since commit a6e8c07a330a
 > ("package/autoconf: bump version to 2.73"), as autoconf 2.72 never
 > selected C23. It therefore affects 2026.08 and later. The 2026.05.x and
 > older maintenance branches still use autoconf 2.72 and are not
 > affected.

 > Fixes:
 > https://autobuild.buildroot.org/results/7d5050c54ba8319f0fd58336851121f5e127b1aa

 > Fixes: a6e8c07a330a389e9578d8f1110e41becac264d2 ("package/autoconf: bump version to 2.73")
 > Assisted-by: Claude:claude-opus-5-5
 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Committed, thanks.

Maybe the time has come to drop prboom? It is ancient and is also one of
the few packages using the old SDL (1.2.x) version.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot