From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2115F606A324 for ; Mon, 26 Oct 2026 15:26:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P1cjvU+T Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xLMa3-0001gN-Ql; Mon, 26 Oct 2026 11:25:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xLMZt-0001eQ-IW for qemu-devel@nongnu.org; Mon, 26 Oct 2026 11:25:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xLMZs-0003Bj-1s for qemu-devel@nongnu.org; Mon, 26 Oct 2026 11:25:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793028333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4AkSm7UIYJ8W37PyRMNgNJfsI5JwSDbwEwJA1Q/f9tU=; b=P1cjvU+TtN7FPpvi8A/OaCa1MIJrz6BF8dPcSTNl1pM/DpGmV7bP9K0BUKoWwdCFj2tclO GglCItdGUMQads+tpmolfCwDr04dVssv1lNTbujrJHQ53Hzr/6+lKaB+2H9/C5b1LAOlv8 GSK1yxzKfmF9FhvWTKa+Ei2TQ7jXVm0= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-t5x-GF3LNeaICYtSnPLs8g-1; Mon, 26 Oct 2026 11:25:32 -0400 X-MC-Unique: t5x-GF3LNeaICYtSnPLs8g-1 X-Mimecast-MFC-AGG-ID: t5x-GF3LNeaICYtSnPLs8g_1793028331 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 663A2180257E; Mon, 26 Oct 2026 15:25:31 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.2]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 008AD1800586; Mon, 26 Oct 2026 15:25:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 628C221E6A04; Mon, 26 Oct 2026 16:25:28 +0100 (CET) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, Fabiano Rosas , Paolo Bonzini , Laurent Vivier Subject: Re: [PATCH] qtest: ensure socket_accept() return value is initialized In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Mon, 26 Oct 2026 14:32:49 +0000") References: <20261026124043.770095-1-berrange@redhat.com> <87ik2od0tj.fsf@pond.sub.org> Date: Mon, 26 Oct 2026 16:25:28 +0100 Message-ID: <87bj8gcwlz.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.339, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Daniel P. Berrang=C3=A9 writes: > On Mon, Oct 26, 2026 at 02:54:32PM +0100, Markus Armbruster wrote: [...] >> Hmm, should we close(sock) on failure here? > > Opps, yes, you are right - we should in fact fall through to > the cleanup: label, as the intention is 'sock' is closed in > all, as the caller expects socket_accept() to close the sock > in all cases. That's a second bug in my original patch. > > This is pretty unpleasant semantics though - the caller owns > the socket and should own closing it. Oh yes. Even more so since the function is called *_accept(). [...]