From: Markus Armbruster <armbru@redhat.com>
To: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH 0/8] multi-target: remove qmp_query_cpu_definitions duplication
Date: Thu, 15 Oct 2026 07:58:29 +0200 [thread overview]
Message-ID: <87bj8vbj3u.fsf@pond.sub.org> (raw)
In-Reply-To: <20261015005355.62406-1-pierrick.bouvier@oss.qualcomm.com> (Pierrick Bouvier's message of "Thu, 15 Oct 2026 00:53:47 +0000")
Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com> writes:
> This series allows to link multiple targets that define
> qmp_query_cpu_definitions. It simply replaces the duplicated definitions with
> target-specific ones and a single dispatcher. We didn't use yet the dispatcher
> pattern, and it's the first situation where it appears to be a good fit.
>
> A possible alternative would be to introduce this callback directly at
> target-info level, which I think is a less desirable solution, since it would
> ties this API to monitor.
I'm curious... why would such a tie be undesirable?
> If the approach here is accepted, I'll extend this series with
> qmp_query_cpu_model_expansion which follows the same pattern.
> With this, we'll be free to link together almost all the base architectures.
Series
Acked-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2026-10-15 6:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 0:53 [PATCH 0/8] multi-target: remove qmp_query_cpu_definitions duplication Pierrick Bouvier
2026-10-15 0:53 ` [PATCH 1/8] target/arm: rename qmp_query_cpu_definitions to qmp_query_arm_cpu_definitions Pierrick Bouvier
2026-10-15 0:53 ` [PATCH 2/8] target/i386: rename qmp_query_cpu_definitions to qmp_query_i386_cpu_definitions Pierrick Bouvier
2026-10-15 0:53 ` [PATCH 3/8] target/loongarch: rename to qmp_query_loongarch_cpu_definitions Pierrick Bouvier
2026-10-15 0:53 ` [PATCH 4/8] target/mips: rename qmp_query_cpu_definitions to qmp_query_mips_cpu_definitions Pierrick Bouvier
2026-10-15 0:53 ` [PATCH 5/8] target/ppc: rename qmp_query_cpu_definitions to qmp_query_ppc_cpu_definitions Pierrick Bouvier
2026-10-15 0:53 ` [PATCH 6/8] target/riscv: rename to qmp_query_cpu_definitions to qmp_query_riscv_cpu_definitions Pierrick Bouvier
2026-10-15 0:53 ` [PATCH 7/8] target/s390x: rename qmp_query_cpu_definitions to qmp_query_s390x_cpu_definitions Pierrick Bouvier
2026-10-15 0:53 ` [PATCH 8/8] qmp: reimplement qmp_query_cpu_definitions as a dispatcher function Pierrick Bouvier
2026-10-15 5:57 ` Markus Armbruster
2026-10-15 6:14 ` Pierrick Bouvier
2026-10-15 2:20 ` [PATCH 0/8] multi-target: remove qmp_query_cpu_definitions duplication Yonggang Luo
2026-10-15 4:46 ` Yonggang Luo
2026-10-15 5:58 ` Markus Armbruster [this message]
2026-10-15 6:13 ` Pierrick Bouvier
2026-10-15 6:36 ` Yonggang Luo
2026-10-15 7:57 ` Daniel P. Berrangé
2026-10-15 17:57 ` Pierrick Bouvier
2026-10-15 7:59 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bj8vbj3u.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.