From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12820C982EA for ; Wed, 23 Sep 2026 10:48:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x9KWe-0001zu-AI; Wed, 23 Sep 2026 06:48:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x9KWc-0001zF-D4 for qemu-devel@nongnu.org; Wed, 23 Sep 2026 06:48:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x9KWa-0000Q3-MJ for qemu-devel@nongnu.org; Wed, 23 Sep 2026 06:48:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790160508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YJaz5n99nRtHm30lBgTbQ2q1M1aSjrFRVFKliqy0DYI=; b=AnIAkf+xYyG7itfw367amjZ7HSvD6ny8o3UVH3MdbLjLRNFlfhkoGC0qPqLXTHG+lLv7to acHrzvBWC3Yos4VVH7KGh+OJhnpEagDbgMYETeUEfkkthxXK4FXa/MauXjShvLgIqP4YCq YaqGUUc9avGiddasoOrFSpFGR9IIaJQ= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-aFCKgCazO9SiFWgJ0Rs2Sg-1; Wed, 23 Sep 2026 06:48:24 -0400 X-MC-Unique: aFCKgCazO9SiFWgJ0Rs2Sg-1 X-Mimecast-MFC-AGG-ID: aFCKgCazO9SiFWgJ0Rs2Sg_1790160503 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6B38F195606D; Wed, 23 Sep 2026 10:48:22 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.5]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 905CD40E; Wed, 23 Sep 2026 10:48:20 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2467E21E6A04; Wed, 23 Sep 2026 12:48:18 +0200 (CEST) From: Markus Armbruster To: John Snow Cc: qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Fabiano Rosas , Hanna Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Kevin Wolf , Vladimir Sementsov-Ogievskiy , Paolo Bonzini , Zhao Liu , Jason Wang , Eric Blake , qemu-block@nongnu.org, Igor Mammedov , Ani Sinha , "Michael S. Tsirkin" , Peter Xu , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Daniel P. =?utf-8?Q?Berrang=C3=A9?= Subject: Re: [PATCH v2 09/10] qapi: split intro sections for data structs In-Reply-To: <20260921205712.1862167-10-jsnow@redhat.com> (John Snow's message of "Mon, 21 Sep 2026 16:57:11 -0400") References: <20260921205712.1862167-1-jsnow@redhat.com> <20260921205712.1862167-10-jsnow@redhat.com> Date: Wed, 23 Sep 2026 12:48:18 +0200 Message-ID: <87bj9outu5.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org John Snow writes: > The structs of concern in this patch are those for which no other QAPI > definition uses as a data type to describe its own arguments or as a > branch of a union: i.e. they are not currently inlined and as such the > precise semantics of their intro/details split is *currently* of less > concern. > > Of course, they could be inlined in the future, so the semantics of > this split are still worth investigating. > > Review notes: Similar notes as previous patches in this series with > respect to how splits were determined, and why details were not > physically relocated. Help me out, please: which notes exactly? > Signed-off-by: John Snow > --- > qapi/acpi.json | 3 +-- > qapi/block-core.json | 5 ++--- > qapi/compat.json | 3 +-- > qapi/machine.json | 9 ++++----- > 4 files changed, 8 insertions(+), 12 deletions(-) > > diff --git a/qapi/acpi.json b/qapi/acpi.json > index 291a04a7ea4..82e82d7cf89 100644 > --- a/qapi/acpi.json > +++ b/qapi/acpi.json > @@ -13,8 +13,7 @@ > > ## > # @AcpiTableOptions: > -# > -# Specify an ACPI table on the command line to load. > +# Specify an ACPI table on the command line to load. > # > # At most one of @file and @data can be specified. The list of files > # specified by any one of them is loaded and concatenated in order. > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 13981d7e69d..741c8165c06 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -843,9 +843,8 @@ > > ## > # @BlockMeasureInfo: > -# > -# Image file size calculation information. This structure describes > -# the size requirements for creating a new image file. > +# Image file size calculation information. This structure > +# describes the size requirements for creating a new image file. > # > # The size requirements depend on the new image file format. File > # size always equals virtual disk size for the 'raw' format, even for > diff --git a/qapi/compat.json b/qapi/compat.json > index ef1853b9acd..b42d142ddcc 100644 > --- a/qapi/compat.json > +++ b/qapi/compat.json > @@ -37,8 +37,7 @@ > > ## > # @CompatPolicy: > -# > -# Policy for handling deprecated management interfaces. > +# Policy for handling deprecated management interfaces. > # > # This is intended for testing users of the management interfaces. > # # Limitation: covers only syntactic aspects of QMP, i.e. stuff tagged # with feature 'deprecated' or 'unstable'. We may want to extend it # to cover semantic aspects and CLI. # # Limitation: deprecated-output policy @hide is not implemented for # enumeration values. They behave the same as with policy @accept. "This is intended for" caught my eyes. Inlining it feels problematic. For starters, how will "this" be interpreted in the new context? Fortunately, this won't be inlined any time soon: it's used just as argument of -compat, and the CLI isn't QAPIfied. Similar difficulties can arise whenever we inline more than just member descriptions. Avoiding them now feels impractical; we'll have to read the texts in the contexts where the inliner puts them. I see a lot of proofreading and doc editing in our future. > diff --git a/qapi/machine.json b/qapi/machine.json > index 00a03e57b98..b18c6d94a38 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -1629,9 +1629,9 @@ > > ## > # @SMPConfiguration: > -# > -# Schema for CPU topology configuration. A missing value lets QEMU > -# figure out a suitable value based on the ones that are provided. > +# Schema for CPU topology configuration. A missing value lets > +# QEMU figure out a suitable value based on the ones that are > +# provided. > # > # The members other than @cpus and @maxcpus define a topology of > # containers. > @@ -1890,8 +1890,7 @@ > > ## > # @CpuModelInfo: > -# > -# Virtual CPU model. > +# Virtual CPU model. > # > # A CPU model consists of the name of a CPU definition, to which delta > # changes are applied (e.g. features added/removed). Most magic