All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Julius Bairaktaris <julius@bairaktaris.de>, johannes@sipsolutions.net
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] wifi: mac80211: don't reset the TXQ scheduling round number
Date: Wed, 09 Sep 2026 12:54:33 +0200	[thread overview]
Message-ID: <87bja6g0eu.fsf@toke.dk> (raw)
In-Reply-To: <20260908144155.756569-1-julius@bairaktaris.de>

Julius Bairaktaris <julius@bairaktaris.de> writes:

> A round is ended when ieee80211_next_txq() meets a txq whose remembered
> round number is the current one, meaning it has gone full circle.
>
> When the AC exceeds the airtime limit, ieee80211_txq_schedule_start()
> sets the round number to 0 to close the round. The next open round is
> 1. A txq from an earlier round 1 still remembers the "1", so the next
> round stops on it and serves nothing.
>
> Fix: use a separate open/closed flag and let the round number keep
> counting.
>
> Testing: ~4200 skipped selections per 20s without the fix and 20
> skipped selections per 20s with the fix on ath11k (with my AQL series
> applied) at BE 500/1000.
>
> Fixes: 8e4bac067105 ("wifi: mac80211: add a per-PHY AQL limit to improve fairness")
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Julius Bairaktaris <julius@bairaktaris.de>

Seems reasonable:

Reviewed-by: Toke Høiland-Jørgensen <toke@toke.dk>

  reply	other threads:[~2026-09-09 10:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 14:41 [PATCH v2] wifi: mac80211: don't reset the TXQ scheduling round number Julius Bairaktaris
2026-09-09 10:54 ` Toke Høiland-Jørgensen [this message]
2026-09-09 10:57   ` Julius Bairaktaris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bja6g0eu.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=johannes@sipsolutions.net \
    --cc=julius@bairaktaris.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.