From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Julien Stephan <jstephan@baylibre.com>, u-boot@lists.u-boot-project.org
Cc: GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
Tom Rini <trini@konsulko.com>, Ryder Lee <ryder.lee@mediatek.com>,
Weijie Gao <weijie.gao@mediatek.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Igor Belwon <igor.belwon@mentallysanemainliners.org>,
David Lechner <dlechner@baylibre.com>,
Minkyu Kang <mk7.kang@samsung.com>,
Casey Connolly <casey.connolly@linaro.org>,
Tim Harvey <tharvey@gateworks.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
"Lucien.Jheng" <lucienzx159@gmail.com>,
Alice Guo <alice.guo@nxp.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Johan Jonker <jbx6244@gmail.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Pavlo Yadvychuk <pyadvychuk@baylibre.com>,
Macpaul Lin <macpaul.lin@mediatek.com>,
Julien Stephan <jstephan@baylibre.com>,
u-boot@lists.u-boot-project.org
Subject: Re: [PATCH v2] phy: phy-mtk-hdmi: add new driver
Date: Wed, 29 Jul 2026 14:45:03 +0200 [thread overview]
Message-ID: <87bjbqx8vk.fsf@kernel.org> (raw)
In-Reply-To: <20260728-mt8188-add-hdmi-phy-driver-v2-1-8b2893b151ba@baylibre.com>
Hi Julien,
Thank you for the patch.
On Tue, Jul 28, 2026 at 17:01, Julien Stephan <jstephan@baylibre.com> wrote:
> Add a new driver for the HDMI PHY. The driver supports MT8188 and MT8195
> based SoCs. The driver is based on the corresponding kernel driver
> (Commit 7a4ce5a9b674 - phy: mediatek: phy-mtk-hdmi-mt8195: convert from
> round_rate() to determine_rate()).
In the future, consider using standard commit formats, see:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
In this example, that would give us:
commit 7a4ce5a9b674 ("phy: mediatek: phy-mtk-hdmi-mt8195: convert from round_rate() to determine_rate()")
>
> Signed-off-by: Pavlo Yadvychuk <pyadvychuk@baylibre.com>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
I've reviewed this comparing to the upstream linux driver. I don't see
anything strange. This looks like a clean port to me.
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
prev parent reply other threads:[~2026-07-29 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 15:01 [PATCH v2] phy: phy-mtk-hdmi: add new driver Julien Stephan
2026-07-29 12:45 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjbqx8vk.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=GSS_MTK_Uboot_upstream@mediatek.com \
--cc=alice.guo@nxp.com \
--cc=casey.connolly@linaro.org \
--cc=chunfeng.yun@mediatek.com \
--cc=dlechner@baylibre.com \
--cc=igor.belwon@mentallysanemainliners.org \
--cc=jbx6244@gmail.com \
--cc=jstephan@baylibre.com \
--cc=lucienzx159@gmail.com \
--cc=macpaul.lin@mediatek.com \
--cc=mk7.kang@samsung.com \
--cc=neil.armstrong@linaro.org \
--cc=pyadvychuk@baylibre.com \
--cc=quentin.schulz@cherry.de \
--cc=ryder.lee@mediatek.com \
--cc=semen.protsenko@linaro.org \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.