From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Marek Vasut <marek.vasut@mailbox.org>,
Romain Gantois <romain.gantois@bootlin.com>,
u-boot@lists.denx.de
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Tom Rini <trini@konsulko.com>, Lukasz Majewski <lukma@denx.de>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
Quentin Schulz <quentin.schulz@cherry.de>,
Kever Yang <kever.yang@rock-chips.com>,
Peter Robinson <pbrobinson@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
George Chan <gchan9527@gmail.com>,
Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>,
Herve Codina <herve.codina@bootlin.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Simon Glass <sjg@chromium.org>, Peng Fan <peng.fan@nxp.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Kuan-Wei Chiu <visitorckw@gmail.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Stefan Roese <stefan.roese@mailbox.org>,
Philip Molloy <philip.molloy@analog.com>,
Jerome Forissier <jerome.forissier@arm.com>,
David Lechner <dlechner@baylibre.com>,
Julien Stephan <jstephan@baylibre.com>
Subject: Re: [PATCH 2/2] usb: gadget: Add Renesas RZ/N1 USBF controller support
Date: Tue, 30 Jun 2026 10:00:58 +0200 [thread overview]
Message-ID: <87bjcs8nk5.fsf@kernel.org> (raw)
In-Reply-To: <267c7ac5-01f2-4cf1-b0e6-7aa5f5ee224e@mailbox.org>
Hello,
On Thu, Jun 25, 2026 at 14:35, Marek Vasut <marek.vasut@mailbox.org> wrote:
> On 6/25/26 11:05 AM, Romain Gantois wrote:
>> From: Herve Codina <herve.codina@bootlin.com>
>>
>> Add support for the Renesas USBF controller. This is an USB2.0 UDC
>> controller available in the RZ/N1 SoC.
>>
>> This driver was originally written by Hervé Codina for the Linux kernel.
>> Suspend/resume features have been removed in this U-Boot port.
> If this was ported from Linux, please include in the commit message from
> which commit SHA in the Linux kernel this was ported from.
I agree with Marek. Having a reference so that we can compare properly
with linux is important. It helps when the linux driver evolves as well,
to port future changes from there into U-Boot.
Without the linux SHA it's very difficult to to review this patch.
prev parent reply other threads:[~2026-06-30 8:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 9:05 [PATCH 0/2] usb: gadget: Add Renesas RZ/N1 USBF driver Romain Gantois
2026-06-25 9:05 ` [PATCH 1/2] linux/list.h: Add list_is_first() Romain Gantois
2026-06-25 11:17 ` Herve Codina
2026-06-25 16:25 ` Simon Glass
2026-07-02 7:47 ` Romain Gantois
2026-06-25 9:05 ` [PATCH 2/2] usb: gadget: Add Renesas RZ/N1 USBF controller support Romain Gantois
2026-06-25 12:35 ` Marek Vasut
2026-06-30 8:00 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjcs8nk5.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=balaji.selvanathan@oss.qualcomm.com \
--cc=dlechner@baylibre.com \
--cc=gchan9527@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=ilias.apalodimas@linaro.org \
--cc=iwamatsu@nigauri.org \
--cc=jerome.forissier@arm.com \
--cc=jonas@kwiboo.se \
--cc=jstephan@baylibre.com \
--cc=kever.yang@rock-chips.com \
--cc=kory.maincent@bootlin.com \
--cc=lukma@denx.de \
--cc=marek.vasut@mailbox.org \
--cc=neil.armstrong@linaro.org \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=philip.molloy@analog.com \
--cc=quentin.schulz@cherry.de \
--cc=raymond.mao@riscstar.com \
--cc=romain.gantois@bootlin.com \
--cc=sjg@chromium.org \
--cc=stefan.roese@mailbox.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.