From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CFEF3932F1 for ; Wed, 17 Jun 2026 09:06:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781687181; cv=none; b=dOyYVUfzCE0cGKleXb7tAmqF2B0gyHU3buEbdS1zHcqhpNSQhU4LkNDamrVDwKLPRoZ9mDdGTbFLotaDLFfaNVWmUHwweGUs1zBpCMxB8PLzyJM9THaMIrR5gBvM6po3I8BVV8unztVPtn7MS7L+LhZoVsIOrRDNTdzcuY4oof4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781687181; c=relaxed/simple; bh=69WZuOaA5uDn33icQVKr/RJg3X4tdnNGNXmU1ISAwwQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=F08ViCez8lw4hhX9D91qYyTNpG8SC748VT0VK1DqQzB/fuQw+s/W/g8yqxy1eg0+fjCCOJXp9wLip8/zlGVoj6IbrzwcHb8C8E7ihfmY49zSSm+HF3/K/i1e9R0ltbb6XyyBbou3CL+hyD0bagcEr1nP/J4SomsTp0CREXGMXNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TCeul5BK; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=omYqJm3Y; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TCeul5BK"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="omYqJm3Y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781687179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=69WZuOaA5uDn33icQVKr/RJg3X4tdnNGNXmU1ISAwwQ=; b=TCeul5BKjlp8XAOdMPwAz9lrX/X+cmsSFxdLtV7k+0oqG4CHoxmD1/fpGSzC+NEfleECO1 0p2MILKXQx/DWef+N4hmwbZrMB1ebsk0JY+1gj5raQ33fxpx+vcfL95z6ZDwfh0XG4yJcj mL3P35MrZmZDj4SfqbPSrMLMFgEa8TM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-h6kMUsxCNLCaxjAMficWWg-1; Wed, 17 Jun 2026 05:06:18 -0400 X-MC-Unique: h6kMUsxCNLCaxjAMficWWg-1 X-Mimecast-MFC-AGG-ID: h6kMUsxCNLCaxjAMficWWg_1781687177 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-461da6328c9so507766f8f.1 for ; Wed, 17 Jun 2026 02:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781687177; x=1782291977; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=69WZuOaA5uDn33icQVKr/RJg3X4tdnNGNXmU1ISAwwQ=; b=omYqJm3Y3d6sWHBMiio2UhE6hR1M2vcnpPoyqpdzBMMUK/HhpAOXO2mkZuuvm1CRwl SQfepF6GNbq5DYWL/KhAkwFxPZjq5R1XihXhaj5b9VWGKkp4TSbn/P/BXZTrUY+/kmKH SHzNBJxhaZAx8IIM6fEf6YO5avjOdciZZg2Jbufsh6Sx96+fgb/GcOWwr+jIw72g2Zui aW4QPonVLtl6OwSNLkBbnyHcbeedAb9mR/TpFZVYGgpSZatpqHMCKG3vGeO5YjBTDFLw cpE4R0zjjVXwgrNtVeABo2fFgv15Bd7uvYM5S6lRpbD0iPFQUMCEOJRYD3ltS+uQ30G/ +sdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781687177; x=1782291977; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=69WZuOaA5uDn33icQVKr/RJg3X4tdnNGNXmU1ISAwwQ=; b=PeoniSR5PlZ6aOiZ1ONwc4DvJPZQtvHe168EStdIMFagKurtuV0z2k6+sSNVLEYcCC UWR6Adi2UeaRTDCRHg8lhZnGEBgLK1HZ3UFyqfYyQeqWz1RGX0Uf5bqGhy8PKqrLoXJ3 D3kO0qE7iLeGAJE3zdJlqhyRwGE5LEG55oJX9VKktUyPvpvYm8gFYcnew1qxDtfKbVNw BNbiuS3aMT5fov/Fw2aQ5FMCLoTCembsHk1p4AZZ07oFvjZWuhW/cHUk2Wkh15NUpBo6 wuCDOT7aYPWCQcg38QoCuBGc477jHifFmrJg9tC/zMC3JIH4Cp8InExg+Cyaql2+cC3+ 6hfQ== X-Forwarded-Encrypted: i=1; AFNElJ9WJ59KrhWHJ3V08UOQe2fufNKmoXlT067X+WLo0qWqHcBVi9yrr09GC6vHDRBO3KsrTgA=@vger.kernel.org X-Gm-Message-State: AOJu0YyCukZN7R7VXXIFnNBb6f22+yV1zJSOIM9z/HVdq8Ld3CDEWClR 9toeNw1FJwgoVCsPfz4GDJRE//OGB55dTYSl6OJ263y9lgFdvHU2IQBQUNQzJnFtiZN+yA19UaQ +ka/GMtD3GIBTzHVb5SDqkT5f7FMOzdqNigGOGwYzGNpnLaiSSZk5yA== X-Gm-Gg: AfdE7clTq5Fomr0eXzVTzjJwZQNlzvzjonddfYFZcAtS5BW07900UGrovy2JjH2t8Rg zBBLNvP69yNe+9Cl64MvTV+w18d708v6nbBpbzm9wZibpRIlFDVRWrFDksC0P2tufhOx52wb//D DgNoOtaShte09QKgJEKnzXHGQvODW0X7X0ExPZM5hrKlma9ByuOR7n9/BzVEfo3yw+CcghbIyBB GIOK2jveLB6OeGlrJZyv2AcyxfTvsm58oymzDgwevdq+KIRM3obhtPs++9ukoAAf0oVhHktzAwg u1P3CteAMU6DOxMQV5Xa9+3/TjVwkvU4U0jGC9yYdW7V4KixmpHTQY389BOKKNEcRjtQT6KbA/w LzAwsfUNdoeZzK/hHBn92Swg5pJE5sgLuZAY= X-Received: by 2002:a05:6000:603:b0:463:1d06:ab33 with SMTP id ffacd0b85a97d-4631d06ab96mr684830f8f.27.1781687176643; Wed, 17 Jun 2026 02:06:16 -0700 (PDT) X-Received: by 2002:a05:6000:603:b0:463:1d06:ab33 with SMTP id ffacd0b85a97d-4631d06ab96mr684756f8f.27.1781687176152; Wed, 17 Jun 2026 02:06:16 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-462a9784497sm3816334f8f.34.2026.06.17.02.06.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 02:06:15 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 9B8D88074B0; Wed, 17 Jun 2026 11:06:14 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Avinash Duduskar , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , John Fastabend , Stanislav Fomichev , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Shuah Khan , Jesper Dangaard Brouer , Mykyta Yatsenko , Leon Hwang , KP Singh , Anton Protopopov , Amery Hung , Eyal Birger , Rong Tao , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v2 1/4] bpf: Initialize the l3mdev field for the fib lookup flow In-Reply-To: <20260616223426.3568080-2-avinash.duduskar@gmail.com> References: <20260616223426.3568080-1-avinash.duduskar@gmail.com> <20260616223426.3568080-2-avinash.duduskar@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 17 Jun 2026 11:06:14 +0200 Message-ID: <87bjd9h6yh.fsf@toke.dk> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain > The helper already initializes the other flow fields the rules path > consumes (flowi4_mark, flowi4_tun_key.tun_id, flowi4_uid and the v6 > counterparts); flowi*_l3mdev was added to that set afterwards and this > helper was never updated to match. ip_route_input_slow() likewise zeroes > the field before its input lookup. Do the same here. So how about we explicitly zero-init the whole struct instead of adding more fields ad-hoc like this? Otherwise this seems like something that is likely to happen again if we ever add another field to the struct? -Toke