From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D03CACD5BD1 for ; Mon, 1 Jun 2026 16:15:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wU5IX-0006iC-17; Mon, 01 Jun 2026 12:15:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wU5IR-0006fh-Nu for qemu-arm@nongnu.org; Mon, 01 Jun 2026 12:15:24 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wU5IQ-00025t-2Q for qemu-arm@nongnu.org; Mon, 01 Jun 2026 12:15:23 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-49050bfe053so72130295e9.3 for ; Mon, 01 Jun 2026 09:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780330520; x=1780935320; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k3AhTnSj0cwgh2xQrOvRyEf14LO6K+Xsg02DkgNzXP8=; b=Dz5bKT4L2Nf2k9s1kNEND5BXt3xyw5jU+GeDECsn+qy2YvlYtXOT0CTSqnnq3wP3Rh qaa877dNsc2/hR/5+IMhFAbHpPWknGmMk7Ob5WwhvYsCqF4hVl84Po1DTiACrWch6Lw6 MYqnlOLOsHtUdz1b5E0c0vHKb+QnKjDsjz1RaJV71rQ4nw24LEY7jpzGV5sOQGo7vkpA rRzwdy48sAho7+c63Bz7wh+iQelKvZAw+iIxGbBWU9zHLtEYwPN+EK8x40i/HeoNU/1a y6S5qpRe8ftYbkxuoah3VdfUMiNv7OAGnDMvudp7rj8luv0fTOY0H/VkPKlHhgjYJ/jm pP4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780330520; x=1780935320; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k3AhTnSj0cwgh2xQrOvRyEf14LO6K+Xsg02DkgNzXP8=; b=YOCiDQYCEeOMhGtnGxoFATqB2neysl9TDyCo36PFIOhX+5MtlBBxLgjiPGPAlFT9n2 XG10YGYmPF6GJkqak9Jg8HzztJ/0fJeyoI72rIxmqfRlnSEOHuGeum/W01S8xQuDWJ5w CAZJz5nMc7kB1tensHovYGtbZloknWGPVM2PUNzD14ioAbF2UhehfbO9177NFSH9cBeK sa9+9Qg7yOQOLxSvLdR+iYCVrmplRMpTsehza56BSq0T13EgzdFwGEfHqHMX5dE0Hovh FF+2TZFMctKt9iWVZ85eMfRcqiaNP8IL/qlqHkVHYuSJ4t55clV+tm0HMhvKSpzDzHjK Y6ow== X-Forwarded-Encrypted: i=1; AFNElJ82U5h9KI4P7QFGCPKXj7DdkJTIXuLUV6wh/IXrXT4TRjY2WnI1SqCZqGMrnZ9VfrXzIdaZ10c9Iw==@nongnu.org X-Gm-Message-State: AOJu0Yy1mZiixkz5y1QVM4SPjfQp4rsZNpub1ApbWjpbmvSPsGRQJSJh LdNhumrj1b7FmfxQAjUpcO+Do+lhZPJqRTVgCAnWJOqRF3n6/ycXCvmODiqKcF1L7nU= X-Gm-Gg: Acq92OEew6oiM09dIGrmY55NHKOJlJR0BK82jhnjTaCVUm5QScm/P0xrUFmCLwTOvhH ShhpoZ4N2FF7EmWtyi8zQFGI2RPQxLZ7E46FMoTirSz0qhrEsj2VhnC5hqtFSWLCzKQxC/mWJd3 gib2Z0EOd9MMW+Y+INQ6X19tNlAC8cZFrPdZWyW8Fh5SIVSHUkn586dh95WBWC7uizbor3MFf2S 4m01T/XynYbcPHDO3kfML2yPhXrLxPRQ5knBj1adsYiZUsFwxZZu9gywqsnAIWn9QXAXuzM3e01 C5/k9b4/VgcqiSGz0bEVTZ7ZN28JLWykOFzP6NChoCdwWQBNJUNMnk8UKLI9T9h2vTAGsP7Lyn6 yaH6lfWRDR3EPdFuj2YpY4yeXS/jS1F9zh40gaU6rKZk2grcanKuiHKO4hLikY9O2u6FwP3eoFU hXWNR+kvGUHEAjhPqWXnuOXXFP90t84ckhVA== X-Received: by 2002:a05:600d:8444:20b0:490:7136:ad02 with SMTP id 5b1f17b1804b1-490b078f2d5mr9036295e9.7.1780330520170; Mon, 01 Jun 2026 09:15:20 -0700 (PDT) Received: from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34b47eesm28511335f8f.9.2026.06.01.09.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 09:15:19 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 02AED5F7C7; Mon, 01 Jun 2026 17:15:18 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, Fabiano Rosas , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Kyle Evans , Peter Maydell , Brian Cain , John Snow , Thomas Huth , Brad Smith , Warner Losh , qemu-arm@nongnu.org, Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9?= , Paolo Bonzini , Jiaxun Yang , Richard Henderson , Song Gao , Cornelia Huck Subject: Re: [PATCH 2/3] gitlab: work around the inability to build targets for MacOS In-Reply-To: <57d0477a-3bbd-4948-8e18-33df41991545@oss.qualcomm.com> (Pierrick Bouvier's message of "Mon, 1 Jun 2026 08:58:34 -0700") References: <20260601143129.144786-1-alex.bennee@linaro.org> <20260601143129.144786-3-alex.bennee@linaro.org> <57d0477a-3bbd-4948-8e18-33df41991545@oss.qualcomm.com> User-Agent: mu4e 1.14.1; emacs 30.1 Date: Mon, 01 Jun 2026 17:15:17 +0100 Message-ID: <87bjduxmne.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Pierrick Bouvier writes: > On 6/1/2026 7:31 AM, Alex Benn=C3=A9e wrote: >> Unfortunately a previous fix to ensure .ninja-goals was set for the >> TCG tests broken the ability to run check-functional-FOO. As we have >> now reverted we need a solution for the MacOS gitlab run. The simplest >> is to add an explicit make invocation to build the signed binaries >> before we run the tests. >>=20 >> Signed-off-by: Alex Benn=C3=A9e >> --- >> .gitlab-ci.d/macos.yml | 3 +++ >> 1 file changed, 3 insertions(+) >>=20 >> diff --git a/.gitlab-ci.d/macos.yml b/.gitlab-ci.d/macos.yml >> index f61750a3f4a..8366b4ad564 100644 >> --- a/.gitlab-ci.d/macos.yml >> +++ b/.gitlab-ci.d/macos.yml >> @@ -29,6 +29,7 @@ >> - cd build >> - ../configure --enable-werror $CONFIGURE_ARGS || { cat config.log = meson-logs/meson-log.txt; exit 1; } >> - $MAKE -j$(sysctl -n hw.ncpu) >> + - for TARGET in $TEST_BINARIES ; do $MAKE $TARGET ; done >> - for TARGET in $TEST_TARGETS ; do $MAKE $TARGET ; done >>=20=20 >> aarch64-macos-15-build: >> @@ -44,6 +45,7 @@ aarch64-macos-15-build: >> --cross-prefix-i386=3Di686-elf- >> --cross-prefix-x86_64=3Dx86_64-elf- >> --disable-plugins >> + TEST_BINARIES: qemu-system-aarch64 qemu-system-i386 qemu-system-x86= _64 >> TEST_TARGETS: check-unit run-tcg-tests-aarch64-softmmu run-tcg-test= s-i386-softmmu run-tcg-tests-x86_64-softmmu >>=20=20 >> aarch64-macos-26-build: >> @@ -60,4 +62,5 @@ aarch64-macos-26-build: >> --cross-prefix-i386=3Di686-elf- >> --cross-prefix-x86_64=3Dx86_64-elf- >> --disable-plugins >> + TEST_BINARIES: qemu-system-aarch64 qemu-system-i386 qemu-system-x86= _64 >> TEST_TARGETS: check-unit run-tcg-tests-aarch64-softmmu run-tcg-test= s-i386-softmmu run-tcg-tests-x86_64-softmmu > > Could make all be enough? No - not without the goal having the signed binaries in them. > > Reviewed-by: Pierrick Bouvier --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro