From: Petr Machata <petrm@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>, <shuah@kernel.org>,
<petrm@nvidia.com>, <gal@nvidia.com>, <leitao@debian.org>,
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net-next 3/3] selftests: net: py: add cmd info for ksft_wait failure
Date: Tue, 24 Feb 2026 14:05:04 +0100 [thread overview]
Message-ID: <87bjhegu51.fsf@nvidia.com> (raw)
In-Reply-To: <20260223202633.4126087-4-kuba@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes:
> Gal recently complained:
>
> When [ksft_wait failure] happens, the test fails with a cryptic
> message:
> # Exception| Exception: Did not receive ready message
>
> Let's try to include the stdout/stderr of the command we tried
> to start. E.g. for cmd("false", ksft_wait=True):
>
> # Exception| lib.py.utils.CmdInitFailure: Did not receive ready message
> # Exception| CMD: false
> # Exception| EXIT: 1
>
> We need to factor out _process_terminate() otherwise the exit
> path may try to write to already disconnected self.ksft_term_fd.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Petr Machata <petrm@nvidia.com>
next prev parent reply other threads:[~2026-02-24 13:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 20:26 [PATCH net-next 0/3] selftests: net: py: improve bkg() error reporting Jakub Kicinski
2026-02-23 20:26 ` [PATCH net-next 1/3] selftests: net: py: avoid masking exceptions in bkg() failures Jakub Kicinski
2026-02-24 13:28 ` Petr Machata
2026-02-23 20:26 ` [PATCH net-next 2/3] selftests: net: py: use repr(cmd) for failure exceptions Jakub Kicinski
2026-02-24 13:03 ` Petr Machata
2026-02-23 20:26 ` [PATCH net-next 3/3] selftests: net: py: add cmd info for ksft_wait failure Jakub Kicinski
2026-02-24 13:05 ` Petr Machata [this message]
2026-02-24 11:12 ` [PATCH net-next 0/3] selftests: net: py: improve bkg() error reporting Simon Horman
2026-02-25 4:09 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjhegu51.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.