From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B03EAECD993 for ; Thu, 5 Feb 2026 17:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7+1Ox2tgBV/n5luMpvBRENXw2cv+3ezTfaic0RWxrQM=; b=s5Mvcw+z9B3vBh ulOsofGfZds6640AyNnlqrPZqghKdc4NQRMXyJWb990Bi8kmoNqamTEMpAsHAgF3Su2fmJ5juTXkT kcahRov64febjdl2Ikrg4X/OcZHcqYKlkMdfv7ZIObbCIFxq/YscZPOqzUG+A+qnCf/WVvwvDhfoe Yaen+z2a+lMJ/fuaDhkQuyLNTBU6MiT7wRX69ZTuZ66etg70cl7My2NYnikxq1EQx7AwdWlzG5HfY RuaRrs7Qn2w1fIL/d6HtxLga8iedluEvRzU90qFlFWbyvSjDfTiR67fTyKFYQf24ScOr96g0jDAYK +kZ+VS+K0bu9OmerKyFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vo3Kc-0000000AJFj-3nUX; Thu, 05 Feb 2026 17:39:54 +0000 Received: from smtpout-04.galae.net ([185.171.202.116]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vo3KZ-0000000AJFO-05Ss for linux-mtd@lists.infradead.org; Thu, 05 Feb 2026 17:39:53 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 405BEC243B0; Thu, 5 Feb 2026 17:39:55 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id EC8AA6074D; Thu, 5 Feb 2026 17:39:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B160C102F1B6D; Thu, 5 Feb 2026 18:39:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770313188; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=m5bZ0GbyBq2QVmRhYdoLegbe54IqW06SZN2AvRVDWyo=; b=dDiXS8Bs+DJPLycI9dC8wYV3oa+ZNSsQMS1HwuWuKWiT5DRf9iH8wZtCUG4P/WgYQEW7YD RlnsVErwGI2UeiBRUVeAUy/QDvk3VKVRr98m7RoN//wwQ8lqEdZeDlbNWj0J8ouvMn1HPy T7s0ZCQVP+InnKgqFTFOV6HA31uoi30MOOpc8jKp+ot4OW1XArg+UBuMx5UfJIGjqfhv+O iNql0bUtA6Ecy91BK65fJlnOztGWix4BnpGDoI21deGLLm6f0bNyQy+kiIJnlynyO0f1G9 LbvYCxDfTZCxMP6JHi1Keb0+hV4jyksJhGRoeiO3u3+5JYMC6UTkvn8142eyXw== From: Miquel Raynal To: Santhosh Kumar K Cc: , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v2 09/12] spi: cadence-quadspi: add PHY tuning infrastructure In-Reply-To: <20260113141617.1905039-10-s-k6@ti.com> (Santhosh Kumar K.'s message of "Tue, 13 Jan 2026 19:46:14 +0530") References: <20260113141617.1905039-1-s-k6@ti.com> <20260113141617.1905039-10-s-k6@ti.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Thu, 05 Feb 2026 18:39:45 +0100 Message-ID: <87bji3gkda.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260205_093951_202644_6557ED63 X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gMTMvMDEvMjAyNiBhdCAxOTo0NjoxNCArMDUzMCwgU2FudGhvc2ggS3VtYXIgSyA8cy1rNkB0 aS5jb20+IHdyb3RlOgoKPiBJbXBsZW1lbnQgdGhlIHNwaV9jb250cm9sbGVyX21lbV9vcHMgZXhl Y3V0ZV90dW5pbmcgY2FsbGJhY2sgdG8gZW5hYmxlCj4gUEhZIHR1bmluZyBzdXBwb3J0IGZvciB0 aGUgQ2FkZW5jZSBjb250cm9sbGVyLiBQSFkgdHVuaW5nIG9wdGltaXplcyBkYXRhCj4gY2FwdHVy ZSB0aW1pbmcgYXQgaGlnaCBmcmVxdWVuY2llcyBieSBjYWxpYnJhdGluZyB0aGUgcmVhZCBkYXRh IGNhcHR1cmUKPiBkZWxheSB0aHJvdWdoIHRoZSBjb250cm9sbGVyJ3MgUEhZIGludGVyZmFjZS4K Pgo+IFR1bmluZyBhbGdvcml0aG0gZnVuY3Rpb25zIChjcXNwaV9waHlfdHVuaW5nX2Rkci9zZHIg YW5kCj4gY3FzcGlfcGh5X3ByZS9wb3N0X2NvbmZpZykgYXJlIHBsYWNlaG9sZGVycyB0byBiZSBp bXBsZW1lbnRlZAo+IGluIHN1YnNlcXVlbnQgY29tbWl0cy4KPgo+IFNpZ25lZC1vZmYtYnk6IFNh bnRob3NoIEt1bWFyIEsgPHMtazZAdGkuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3NwaS9zcGktY2Fk ZW5jZS1xdWFkc3BpLmMgfCAyNDEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDEg ZmlsZSBjaGFuZ2VkLCAyNDEgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv c3BpL3NwaS1jYWRlbmNlLXF1YWRzcGkuYyBiL2RyaXZlcnMvc3BpL3NwaS1jYWRlbmNlLXF1YWRz cGkuYwo+IGluZGV4IDBkZjI4NmQyNDI1Ni4uYjhiMGU4NWY0ZjY4IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvc3BpL3NwaS1jYWRlbmNlLXF1YWRzcGkuYwo+ICsrKyBiL2RyaXZlcnMvc3BpL3NwaS1j YWRlbmNlLXF1YWRzcGkuYwo+IEBAIC0zMiw2ICszMiw3IEBACj4gIAo+ICAjZGVmaW5lIENRU1BJ X05BTUUJCQkiY2FkZW5jZS1xc3BpIgo+ICAjZGVmaW5lIENRU1BJX01BWF9DSElQU0VMRUNUCQk0 Cj4gKyNkZWZpbmUgQ1FTUElfQU02NTRfTk9OX1BIWV9DTEtfUkFURQkyNTAwMDAwMAo+ICAKPiAg c3RhdGljX2Fzc2VydChDUVNQSV9NQVhfQ0hJUFNFTEVDVCA8PSBTUElfREVWSUNFX0NTX0NOVF9N QVgpOwo+ICAKPiBAQCAtNjUsNiArNjYsNyBAQCBzdHJ1Y3QgY3FzcGlfc3Q7Cj4gIHN0cnVjdCBj cXNwaV9mbGFzaF9wZGF0YSB7Cj4gIAlzdHJ1Y3QgY3FzcGlfc3QJKmNxc3BpOwo+ICAJdTMyCQlj bGtfcmF0ZTsKPiArCXUzMgkJbm9uX3BoeV9jbGtfcmF0ZTsKClRoaXMgaXMgdGhlIHNlY29uZCAo YW5kIGxhc3QpIG1haW4gaXNzdWUgSSBoYXZlIHdpdGggdGhlIHNlcmllcyBhcyBpdCBpcwpyaWdo dCBub3cuIFdlIGNhbm5vdCBzZXQgdGhpcyB0eXBlIG9mIGZyZXF1ZW5jeSBpbiB0aGUgZHJpdmVy IElNTywgaXQgaXMKdG9vIGJvYXJkIHNwZWNpZmljLgoKV2UgY3VycmVudGx5IGhhdmUgYSBEVCBw cm9wZXJ0eSBmb3IgdGhlIFNQSSBtYXhpbXVtIHN1cHBvcnRlZApmcmVxdWVuY3kuIEkgYmVsaWV2 ZSB0aGlzIGlzIG5vIGxvbmdlciBlbm91Z2guIFdoeSBub3QgbWFraW5nIHRoaXMKZnJlcXVlbmN5 IHByb3BlcnR5IGFuIGFycmF5PyBGaXJzdCBmcmVxdWVuY3kgd291bGQgYmUgdGhlIGRlZmF1bHQs Cm5vbiB0dW5lZCBtYXhpbXVtIGZyZXF1ZW5jeS4gVGhlIHNlY29uZCB3b3VsZCBiZSB0aGUgbWF4 aW11bSBmcmVxdWVuY3kKcmVhY2hhYmxlIHdoZW4gdHVuaW5nIHRoZSBQSFkuCgpUaGUgcmVzdCBv ZiB0aGUgcGF0Y2ggTEdUTSBvdGhlcndpc2UsIGJ1dCB0aGVyZSBpcyB0aGlzIGZyZXF1ZW5jeQpp bmZvcm1hdGlvbiB3aGljaCBJIHRoaW5rIHNob3VsZCBiZSBoYW5kbGVkIHdpdGggbW9yZSBjYXJl LgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9BAC2F8BC3 for ; Thu, 5 Feb 2026 17:39:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770313190; cv=none; b=khh7D2tG0WC/f8XSZnZ2/AxiP/Oe6EUtc6x5JEli2P4O89mXzLnj2wDuZYUeMjm2lG8JkJp8StqZyLL1ggmB0e3rtf/hUC8/at7XLryO58LdErrdNSQpAcAZQRLH9FhfUrVFuUa5lvq0W4U/NbDtFkx028UDqiM20DOuf+8d8OM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770313190; c=relaxed/simple; bh=hAkW6nhF+LUmUNanvGpF1I/RUdvXsSUbwnPXo59V8eU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=W0HXSr5fmOMltOqUdjYe0ucgKgsy3ySe+P/mW/Xz5i5gzmUtUsAuMulHu5IQp+h0Lj/FdFry3lwKu9TLN+dh0fQM2loww7cTH3mmWBugO0SuJZ5jcNHiFyGdxYjxhduUCNPPJFubtX4WY9dgWqsOMmgODyhlK7/psr+rlZfmrRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=dDiXS8Bs; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dDiXS8Bs" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 402A34E42424; Thu, 5 Feb 2026 17:39:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id EC8AA6074D; Thu, 5 Feb 2026 17:39:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B160C102F1B6D; Thu, 5 Feb 2026 18:39:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770313188; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=m5bZ0GbyBq2QVmRhYdoLegbe54IqW06SZN2AvRVDWyo=; b=dDiXS8Bs+DJPLycI9dC8wYV3oa+ZNSsQMS1HwuWuKWiT5DRf9iH8wZtCUG4P/WgYQEW7YD RlnsVErwGI2UeiBRUVeAUy/QDvk3VKVRr98m7RoN//wwQ8lqEdZeDlbNWj0J8ouvMn1HPy T7s0ZCQVP+InnKgqFTFOV6HA31uoi30MOOpc8jKp+ot4OW1XArg+UBuMx5UfJIGjqfhv+O iNql0bUtA6Ecy91BK65fJlnOztGWix4BnpGDoI21deGLLm6f0bNyQy+kiIJnlynyO0f1G9 LbvYCxDfTZCxMP6JHi1Keb0+hV4jyksJhGRoeiO3u3+5JYMC6UTkvn8142eyXw== From: Miquel Raynal To: Santhosh Kumar K Cc: , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v2 09/12] spi: cadence-quadspi: add PHY tuning infrastructure In-Reply-To: <20260113141617.1905039-10-s-k6@ti.com> (Santhosh Kumar K.'s message of "Tue, 13 Jan 2026 19:46:14 +0530") References: <20260113141617.1905039-1-s-k6@ti.com> <20260113141617.1905039-10-s-k6@ti.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Thu, 05 Feb 2026 18:39:45 +0100 Message-ID: <87bji3gkda.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 13/01/2026 at 19:46:14 +0530, Santhosh Kumar K wrote: > Implement the spi_controller_mem_ops execute_tuning callback to enable > PHY tuning support for the Cadence controller. PHY tuning optimizes data > capture timing at high frequencies by calibrating the read data capture > delay through the controller's PHY interface. > > Tuning algorithm functions (cqspi_phy_tuning_ddr/sdr and > cqspi_phy_pre/post_config) are placeholders to be implemented > in subsequent commits. > > Signed-off-by: Santhosh Kumar K > --- > drivers/spi/spi-cadence-quadspi.c | 241 ++++++++++++++++++++++++++++++ > 1 file changed, 241 insertions(+) > > diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-= quadspi.c > index 0df286d24256..b8b0e85f4f68 100644 > --- a/drivers/spi/spi-cadence-quadspi.c > +++ b/drivers/spi/spi-cadence-quadspi.c > @@ -32,6 +32,7 @@ >=20=20 > #define CQSPI_NAME "cadence-qspi" > #define CQSPI_MAX_CHIPSELECT 4 > +#define CQSPI_AM654_NON_PHY_CLK_RATE 25000000 >=20=20 > static_assert(CQSPI_MAX_CHIPSELECT <=3D SPI_DEVICE_CS_CNT_MAX); >=20=20 > @@ -65,6 +66,7 @@ struct cqspi_st; > struct cqspi_flash_pdata { > struct cqspi_st *cqspi; > u32 clk_rate; > + u32 non_phy_clk_rate; This is the second (and last) main issue I have with the series as it is right now. We cannot set this type of frequency in the driver IMO, it is too board specific. We currently have a DT property for the SPI maximum supported frequency. I believe this is no longer enough. Why not making this frequency property an array? First frequency would be the default, non tuned maximum frequency. The second would be the maximum frequency reachable when tuning the PHY. The rest of the patch LGTM otherwise, but there is this frequency information which I think should be handled with more care. Thanks, Miqu=C3=A8l