From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AED47D3F07A for ; Wed, 28 Jan 2026 15:22:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vl7NM-00072i-A6; Wed, 28 Jan 2026 10:22:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vl7NH-0006yy-G5 for qemu-devel@nongnu.org; Wed, 28 Jan 2026 10:22:32 -0500 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vl7NG-0003MS-0d for qemu-devel@nongnu.org; Wed, 28 Jan 2026 10:22:31 -0500 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8E65E33C22; Wed, 28 Jan 2026 15:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769613748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QzvUzcUw8ih5wPRg3iOp2onB7d99t7EXgikd0yJWMtM=; b=YNdQFddDc59aWWIKinHm7NdBXd9nssGRaMUd4sHXp7QbjEA/H2B+XKdeRQHDygpVWWwc+h ux36pJOHQkiYZ30CB2I6OCPnymFpcnp80XbWs5p654AqBpI/aWYxorMvqG0X9+yMc1pCVZ MfjiuO+v6VOUKZVpLTS1Laag12Vrv4w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769613748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QzvUzcUw8ih5wPRg3iOp2onB7d99t7EXgikd0yJWMtM=; b=Kvm5q9vRNu7dMDS9jv6Xb/9BYWiTuw6jf7ymDkFIyNSSfyA6u2oxun12zglZ7RrAevMQWD I9c4hbMgQe7EM6AQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769613748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QzvUzcUw8ih5wPRg3iOp2onB7d99t7EXgikd0yJWMtM=; b=YNdQFddDc59aWWIKinHm7NdBXd9nssGRaMUd4sHXp7QbjEA/H2B+XKdeRQHDygpVWWwc+h ux36pJOHQkiYZ30CB2I6OCPnymFpcnp80XbWs5p654AqBpI/aWYxorMvqG0X9+yMc1pCVZ MfjiuO+v6VOUKZVpLTS1Laag12Vrv4w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769613748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QzvUzcUw8ih5wPRg3iOp2onB7d99t7EXgikd0yJWMtM=; b=Kvm5q9vRNu7dMDS9jv6Xb/9BYWiTuw6jf7ymDkFIyNSSfyA6u2oxun12zglZ7RrAevMQWD I9c4hbMgQe7EM6AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0BAEC3EA61; Wed, 28 Jan 2026 15:22:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 86JoL7MpemldNgAAD6G6ig (envelope-from ); Wed, 28 Jan 2026 15:22:27 +0000 From: Fabiano Rosas To: Peter Xu , qemu-devel@nongnu.org Cc: peterx@redhat.com, Lukas Straub , Prasad Pandit , Juraj Marcin Subject: Re: [PATCH v2 14/24] migration: Introduce qemu_savevm_state_end() In-Reply-To: <20260127185254.3954634-15-peterx@redhat.com> References: <20260127185254.3954634-1-peterx@redhat.com> <20260127185254.3954634-15-peterx@redhat.com> Date: Wed, 28 Jan 2026 12:22:25 -0300 Message-ID: <87bjidg3ta.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[web.de]; MISSING_XM_UA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[redhat.com,web.de]; RCPT_COUNT_FIVE(0.00)[6]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:email] Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > Introduce a helper to end a migration stream. > > Signed-off-by: Peter Xu > --- > migration/savevm.h | 1 + > migration/colo.c | 2 +- > migration/savevm.c | 12 +++++++++--- > 3 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/migration/savevm.h b/migration/savevm.h > index ea01ca63ec..d0596d1d62 100644 > --- a/migration/savevm.h > +++ b/migration/savevm.h > @@ -49,6 +49,7 @@ void qemu_savevm_state_pending_estimate(uint64_t *must_precopy, > uint64_t *can_postcopy); > int qemu_savevm_state_complete_precopy_iterable(QEMUFile *f, bool in_postcopy); > bool qemu_savevm_state_postcopy_prepare(QEMUFile *f, Error **errp); > +void qemu_savevm_state_end(QEMUFile *f); > void qemu_savevm_send_ping(QEMUFile *f, uint32_t value); > void qemu_savevm_send_open_return_path(QEMUFile *f); > int qemu_savevm_send_packaged(QEMUFile *f, const uint8_t *buf, size_t len); > diff --git a/migration/colo.c b/migration/colo.c > index 0b1a58cd8f..db804b25a9 100644 > --- a/migration/colo.c > +++ b/migration/colo.c > @@ -470,7 +470,7 @@ static int colo_do_checkpoint_transaction(MigrationState *s, > * to be blocked here. > */ > qemu_savevm_state_complete_precopy_iterable(s->to_dst_file, false); > - qemu_put_byte(s->to_dst_file, QEMU_VM_EOF); > + qemu_savevm_state_end(s->to_dst_file); > > /* > * We need the size of the VMstate data in Secondary side, > diff --git a/migration/savevm.c b/migration/savevm.c > index d41e89228d..a787691352 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -1065,6 +1065,12 @@ static int vmstate_save(QEMUFile *f, SaveStateEntry *se, JSONWriter *vmdesc, > } > return 0; > } > + > +void qemu_savevm_state_end(QEMUFile *f) > +{ > + qemu_put_byte(f, QEMU_VM_EOF); > +} > + > /** > * qemu_savevm_command_send: Send a 'QEMU_VM_COMMAND' type element with the > * command and associated data. > @@ -1555,7 +1561,7 @@ void qemu_savevm_state_complete_postcopy(QEMUFile *f) > } > } > > - qemu_put_byte(f, QEMU_VM_EOF); > + qemu_savevm_state_end(f); > qemu_fflush(f); > } > > @@ -1699,7 +1705,7 @@ int qemu_savevm_state_complete_precopy_non_iterable(QEMUFile *f, > > if (!in_postcopy) { > /* Postcopy stream will still be going */ > - qemu_put_byte(f, QEMU_VM_EOF); > + qemu_savevm_state_end(f); > > if (vmdesc) { > json_writer_end_array(vmdesc); > @@ -1879,7 +1885,7 @@ int qemu_save_device_state(QEMUFile *f) > } > } > > - qemu_put_byte(f, QEMU_VM_EOF); > + qemu_savevm_state_end(f); > > return qemu_file_get_error(f); > } Reviewed-by: Fabiano Rosas