From: Fabiano Rosas <farosas@suse.de>
To: Harsh Prateek Bora <harshpb@linux.ibm.com>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, peterx@redhat.com, Fabian Vogt <fvogt@suse.de>,
Nicholas Piggin <npiggin@gmail.com>,
Chinmay Rath <rathc@linux.ibm.com>,
gautam@linux.ibm.com
Subject: Re: [PATCH v2 1/2] target/ppc: Fix env->quiesced migration
Date: Thu, 08 Jan 2026 09:56:48 -0300 [thread overview]
Message-ID: <87bjj41cvj.fsf@suse.de> (raw)
In-Reply-To: <31a61dff-d30d-4c93-8fc1-391c99d32b42@linux.ibm.com>
Harsh Prateek Bora <harshpb@linux.ibm.com> writes:
> One minor comment below:
>
> <snip>
>
> On 05/01/26 2:30 pm, Harsh Prateek Bora wrote:
>>> diff --git a/target/ppc/machine.c b/target/ppc/machine.c
>>> index d72e5ecb94..ba63a7debb 100644
>>> --- a/target/ppc/machine.c
>>> +++ b/target/ppc/machine.c
>>> @@ -6,6 +6,7 @@
>>> #include "mmu-hash64.h"
>>> #include "migration/cpu.h"
>>> #include "qapi/error.h"
>>> +#include "qemu/error-report.h"
>
> I do not see any error reporting being added in the patch below.
> Does this header inclusion need to be removed ?
>
Well spotted, that's a leftover from a previous implementation.
next prev parent reply other threads:[~2026-01-08 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 16:45 [PATCH v2 0/2] ppc: Fix migration issue with quiesced state Fabiano Rosas
2025-12-17 16:45 ` [PATCH v2 1/2] target/ppc: Fix env->quiesced migration Fabiano Rosas
2026-01-05 9:00 ` Harsh Prateek Bora
2026-01-08 6:27 ` Harsh Prateek Bora
2026-01-08 12:56 ` Fabiano Rosas [this message]
2025-12-17 16:45 ` [PATCH v2 2/2] tests/functional: Add a OS level migration test for pseries Fabiano Rosas
2026-01-05 10:05 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjj41cvj.fsf@suse.de \
--to=farosas@suse.de \
--cc=fvogt@suse.de \
--cc=gautam@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rathc@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.