From: Markus Armbruster <armbru@redhat.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Honglei Huang <honghuan@amd.com>,
alex.bennee@linaro.org, odaki@rsg.ci.i.u-tokyo.ac.jp,
armbru@redhat.com, mst@redhat.com, cohuck@redhat.com,
pbonzini@redhat.com, qemu-devel@nongnu.org, Ray.Huang@amd.com
Subject: Re: [v4] virtio-gpu: use consistent error checking style for virtio_gpu_create_mapping_iov
Date: Mon, 17 Nov 2025 14:22:05 +0100 [thread overview]
Message-ID: <87bjl0pzeq.fsf@pond.sub.org> (raw)
In-Reply-To: <9f547fbe-ea57-4784-9e37-f79b52b551a9@collabora.com> (Dmitry Osipenko's message of "Mon, 17 Nov 2025 15:03:24 +0300")
Dmitry Osipenko <dmitry.osipenko@collabora.com> writes:
> On 11/17/25 13:51, Honglei Huang wrote:
>> diff --git a/hw/display/virtio-gpu-rutabaga.c b/hw/display/virtio-gpu-rutabaga.c
>> index ed5ae52acb..ea2928b706 100644
>> --- a/hw/display/virtio-gpu-rutabaga.c
>> +++ b/hw/display/virtio-gpu-rutabaga.c
>> @@ -466,7 +466,7 @@ rutabaga_cmd_attach_backing(VirtIOGPU *g, struct virtio_gpu_ctrl_command *cmd)
>>
>> ret = virtio_gpu_create_mapping_iov(g, att_rb.nr_entries, sizeof(att_rb),
>> cmd, NULL, &res->iov, &res->iov_cnt);
>> - CHECK(!ret, cmd);
>> + CHECK(ret >= 0, cmd);
>
> virtio_gpu_create_mapping_iov() doesn't return positive values, don't
> see how this change improves anything. You now saying that ret > 0 is
> okay, while it shall never happen.
Please see
Subject: Re: [PATCH] virtio-gpu-virgl: fix error handling in virgl_cmd_resource_create_blob
Date: Mon, 17 Nov 2025 08:49:42 +0100
Message-ID: <87ms4lrtd5.fsf@pond.sub.org>
https://lore.kernel.org/qemu-devel/87ms4lrtd5.fsf@pond.sub.org/
next prev parent reply other threads:[~2025-11-17 13:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 10:51 [v4] virtio-gpu: use consistent error checking style for virtio_gpu_create_mapping_iov Honglei Huang
2025-11-17 11:53 ` Markus Armbruster
2025-11-17 12:03 ` Dmitry Osipenko
2025-11-17 13:22 ` Markus Armbruster [this message]
2025-11-18 1:48 ` Dmitry Osipenko
2025-11-18 5:45 ` Markus Armbruster
2025-11-20 2:51 ` Dmitry Osipenko
2025-11-18 12:32 ` Honglei Huang
2025-11-19 19:16 ` Dmitry Osipenko
2025-11-20 1:29 ` Akihiko Odaki
2025-11-20 2:45 ` Dmitry Osipenko
2025-11-20 1:31 ` Honglei Huang
2025-11-20 2:03 ` Dmitry Osipenko
-- strict thread matches above, loose matches on Subject: below --
2025-11-21 7:58 Honglei Huang
2025-11-21 8:14 ` Honglei Huang
2025-11-21 18:00 ` Dmitry Osipenko
2025-11-24 1:42 ` Honglei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjl0pzeq.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=Ray.Huang@amd.com \
--cc=alex.bennee@linaro.org \
--cc=cohuck@redhat.com \
--cc=dmitry.osipenko@collabora.com \
--cc=honghuan@amd.com \
--cc=mst@redhat.com \
--cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.